Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate builtin addons (links and actions) - no longer included by default #1038

Merged
merged 6 commits into from
May 17, 2017

Conversation

shilman
Copy link
Member

@shilman shilman commented May 16, 2017

Issue: #1017

What I did

Added HISTORY.md to track changes with each release, modeled after
Meteor’s: https://github.com/meteor/meteor/blob/devel/History.md

How to test

Follow instructions in HISTORY.md (if you want)

@codecov
Copy link

codecov bot commented May 16, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@f5bf4dd). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1038   +/-   ##
=========================================
  Coverage          ?   12.51%           
=========================================
  Files             ?      196           
  Lines             ?     4458           
  Branches          ?      713           
=========================================
  Hits              ?      558           
  Misses            ?     3269           
  Partials          ?      631

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5bf4dd...598fd65. Read the comment docs.

@usulpro
Copy link
Member

usulpro commented May 16, 2017

I wonder can we additionally add a deprecating warning to @kadira/storybook-addon-... packages?

@shilman
Copy link
Member Author

shilman commented May 16, 2017

@usulpro I'm not sure I understand your comment. I just deprecated the builtin-ness of the addons, not the addons themselves, so I don't think it's appropriate to deprecate them. What do you think?

@ndelangen
Copy link
Member

I think @shilman means we can deprecate all @kadira/* packages on npm.
We'd need to get membership on those packages, in order to publish.

Copy link
Member

@ndelangen ndelangen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a before and after code example would make this text a lot more understandable.

@shilman
Copy link
Member Author

shilman commented May 16, 2017

OK I understand @usulpro 's @kadira/* deprecation comment now. Thanks!

@shilman
Copy link
Member Author

shilman commented May 16, 2017

@ndelangen Added before/after example. Not sure whether this is the best place for it or format. Suggestions welcome!

Copy link
Member

@usulpro usulpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman merged commit 8c6655f into storybookjs:master May 17, 2017
@shilman shilman added the misc label May 27, 2017
@ndelangen ndelangen changed the title Deprecate builtin addons Deprecate builtin addons (links and actions) - no longer included by default May 27, 2017
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label May 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants