change NPM organisation from kadira to storybook in code #996

aaronmcadam · 2017-05-06T09:31:37Z

Issue: #773

Blocked by

#1004, ~~#1008~~

What I did

Created the codemod

How to test

Run unit tests

TODO

New Package directories and names

Current Repo Path	Suggested Repo Path	Publish Name
packages/getstorybook	packages/cli	@storybook/cli
packages/react-storybook	packages/react	@storybook/react
packages/react-native-storybook	packages/react-native	@storybook/react-native
packages/storybook-ui	packages/ui	@storybook/ui
packages/channels		@storybook/channels
packages/channel-websocket	packages/channels-websocket	@storybook/channels-websocket
packages/addons		@storybook/addons
packages/addon-actions	packages/addons-actions	@storybook/addons-actions
packages/decorator-centered	packages/decorators-centered	@storybook/decorators-centered
packages/storyshots		@storybook/storyshots

codecov · 2017-05-06T09:36:02Z

Codecov Report

Merging #996 into master will increase coverage by 0.05%.
The diff coverage is 6.41%.

@@            Coverage Diff             @@
##           master     #996      +/-   ##
==========================================
+ Coverage   12.51%   12.57%   +0.05%     
==========================================
  Files         196      200       +4     
  Lines        4458     4478      +20     
  Branches      713      714       +1     
==========================================
+ Hits          558      563       +5     
- Misses       3269     3283      +14     
- Partials      631      632       +1

Impacted Files	Coverage Δ
packages/addon-comments/src/manager/index.js	`0% <ø> (ø)`	⬆️
packages/react-storybook/src/server/track_usage.js	`0% <ø> (ø)`	⬆️
packages/addon-options/src/manager/index.js	`0% <ø> (ø)`	⬆️
packages/addon-actions/src/index.js	`0% <ø> (ø)`	⬆️
packages/addon-actions/src/manager.js	`0% <ø> (ø)`	⬆️
packages/getstorybook/lib/detect.js	`0% <ø> (ø)`	⬆️
...toryshots/stories/required_with_context/Welcome.js	`0% <ø> (ø)`	⬆️
packages/addon-knobs/src/register.js	`0% <0%> (ø)`	⬆️
...ts/stories/required_with_context/Button.stories.js	`0% <0%> (ø)`	⬆️
...ents/src/manager/containers/CommentsPanel/index.js	`0% <0%> (ø)`	⬆️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42219f5...bcbc570. Read the comment docs.

aaronmcadam · 2017-05-06T11:11:08Z

@ndelangen Can we confirm what we want the published name these packages to be? Should we drop all storybook- prefixes?

ndelangen

Do we need to add the codemod as a package? I'd think not.

ndelangen · 2017-05-08T15:48:25Z

So I've been trying this, but it would appear that in order to get this to work, all packages must at least have been published once on npm, in order for lerna to be able to bootstrap.

aaronmcadam · 2017-05-08T16:44:47Z

It would be useful for users to migrateOn 8 May 2017 4:22 pm, Norbert de Langen <notifications@github.com> wrote:@ndelangen commented on this pull request. Do we need to add the codemod as a package? I'd think not. —You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.

aaronmcadam · 2017-05-08T16:47:03Z

Lerna doesn't need the packages to be published to bootstrap. Tests will fail though where they reference the new package names.

ndelangen · 2017-05-08T19:24:04Z

Lerna doesn't need the packages to be published to bootstrap

That's what I'm hearing from lerna maintainers, however check the travis logs, bootstrap does fail...

It would be useful for users to migrate

Right, I'd move them somewhere else though, maybe ./migrations. I feel like we should reserve ./packages/ for functional parts of storybook.

ndelangen · 2017-05-09T05:19:19Z

I'd personally like to remove the storybook- prefix, what you you think?

aaronmcadam · 2017-05-09T09:23:55Z

@ndelangen I think we should only have storybook mentioned in the name for the main package.

So the directory structure would go from this:

addon-actions
addon-comments
addon-graphql
addon-info
addon-knobs
addon-notes
addon-options
addons
channel
channel-postmessage
channel-websocket
codemod
decorator-centered
getstorybook
react-native-storybook
react-storybook
storybook-ui
storyshots

to this:

addon-actions
addon-comments
addon-graphql
addon-info
addon-knobs
addon-notes
addon-options
addons
channel
channel-postmessage
channel-websocket
codemod
decorator-centered
getstorybook
native-storybook
storybook
ui
storyshots

aaronmcadam · 2017-05-09T09:27:10Z

@ndelangen regarding the codemod, I understand where you're coming from regarding keeping packages for functionality.

If we move it elsewhere, we'll have to manually manage publishing it.

We might be able to make it work by setting the packages config in lerna.json to take an extra tools directory.

usulpro · 2017-05-09T09:47:45Z

Hi!
Isn't storybook-ui more comfortable than ui as an important part of the core?

And is it clear that native-storybook is related to react-native?

ndelangen · 2017-05-09T11:54:42Z

@ndelangen regarding the codemod, I understand where you're coming from regarding keeping packages for functionality.

If we move it elsewhere, we'll have to manually manage publishing it.

We might be able to make it work by setting the packages config in lerna.json to take an extra tools directory.

Good suggestion! I'm already using the packages config. It's real easy to add a tools folder.

ndelangen · 2017-05-09T11:56:12Z

Isn't storybook-ui more comfortable than ui as an important part of the core?

Do you prefer @storybook/ui or @storybook/storybook-ui?

theinterned · 2017-05-09T17:00:08Z

I agree that @storybook/native-storybook is more confusing then @storybook/react-native-storybook ... the name of the project is react-native so arbitrarily cutting it in half seems odd.

aaronmcadam · 2017-05-09T17:03:27Z

I was trying to aim for parity between the directory names on disk and the package names on npm. So @kadira/react-storybook has gone to @storybooks/storybook. I do agree that the name for the native project is awkward.

aaronmcadam · 2017-05-10T10:53:46Z

Ok, so the latest consensus is:

addon-actions
addon-comments
addon-graphql
addon-info
addon-knobs
addon-notes
addon-options
addons
channel
channel-postmessage
channel-websocket
codemod
decorator-centered
getstorybook
react
react-native
(storybook-ui|ui)
storyshots

ndelangen · 2017-05-10T11:23:20Z

Sorry to through my 2ct in the mix again... Here's my suggestion:

Current Repo Path	Suggested Repo Path	Publish Name
packages/getstorybook	packages/cli	@storybook/cli
packages/react-storybook	packages/react	@storybook/react
packages/react-native-storybook	packages/react-native	@storybook/react-native
packages/storybook-ui	packages/ui	@storybook/ui
packages/channels		@storybook/channels
packages/channel-websocket	packages/channels-websocket	@storybook/channels-websocket
packages/addons		@storybook/addons
packages/addon-actions	packages/addons-actions	@storybook/addons-actions
packages/decorator-centered	packages/decorators-centered	@storybook/decorators-centered
packages/storyshots		@storybook/storyshots

aaronmcadam · 2017-05-10T13:26:27Z

To all those watching this PR, I've added the name changes to the PR description.

usulpro · 2017-05-10T14:20:41Z

Okey
but why @storybook/addons-actions and @storybook/decorators-centered ? (originally it was without s)

And wouldn't it better to rename @storybook/decorators-centered to @storybook/addon-centered since decorator is just a kind of addon?

aaronmcadam · 2017-05-10T14:28:19Z

@usulpro I think we should have the same prefix for these namespaced packages so that it's easier to see that packages are related visually.

I don't mind moving decorators-centered into the addons namespace.

usulpro · 2017-05-12T17:47:55Z

How do you like the idea (if it still possible) to move all addons into a separate folder storybook/addons and remove addon from folder name:
storybook/packages/addon-actions -> storybook/addons/actions

# Conflicts: # examples/cra-storybook/package.json # examples/cra-storybook/src/stories/index.js # examples/test-cra/package.json # examples/test-cra/src/stories/index.js # packages/addon-actions/.storybook/addons.js # packages/addon-comments/.storybook/addons.js # packages/addon-comments/package.json # packages/addon-info/.storybook/addons.js # packages/addon-info/example/story.js # packages/addon-info/package.json # packages/addon-knobs/.storybook/addons.js # packages/addon-knobs/README.md # packages/addon-notes/README.md # packages/addon-notes/package.json # packages/addon-options/.storybook/addons.js # packages/getstorybook/generators/METEOR/template/.stories/index.js # packages/getstorybook/generators/REACT/template/stories/index.js # packages/getstorybook/generators/REACT_NATIVE/template/storybook/addons.js # packages/getstorybook/generators/REACT_NATIVE/template/storybook/stories/index.js # packages/getstorybook/generators/REACT_SCRIPTS/template/src/stories/index.js # packages/react-native-storybook/docs/manual-setup.md # packages/react-native-storybook/package.json # packages/react-native-storybook/src/index.js # packages/react-native-storybook/src/server/addons.js # packages/react-storybook/demo/package.json # packages/react-storybook/demo/src/stories/index.js # packages/react-storybook/src/client/index.js # packages/react-storybook/src/server/addons.js # packages/storyshots/package.json # packages/storyshots/stories/required_with_context/Button.stories.js # packages/storyshots/stories/required_with_context/Welcome.stories.js

…ructure CHANGE folder structure && CHANGE package-names

See: storybookjs#996

See: #996

nx-cloud · 2024-07-23T09:55:45Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bcbc570. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

nx run-many -t build --parallel=3

Sent with 💌 from NxCloud.

arunoda added the in progress label May 6, 2017

aaronmcadam force-pushed the am-change-npm-organisation branch from 36eca2a to 41f9b97 Compare May 6, 2017 09:40

aaronmcadam changed the title ~~feat: add codemod for migrating NPM organisation~~ refactor: change NPM organisation from kadira to storybook May 6, 2017

aaronmcadam force-pushed the am-change-npm-organisation branch 2 times, most recently from 2adbf62 to 3a7e455 Compare May 6, 2017 10:10

feat: add codemod for migrating NPM organisation

144c269

aaronmcadam force-pushed the am-change-npm-organisation branch from 3a7e455 to 144c269 Compare May 6, 2017 10:14

aaronmcadam added 5 commits May 6, 2017 11:27

refactor: update imports

b0c01f6

refactor: update imports in examples

88fdf7e

refactor: update more old references

e989538

docs: update repo URLs in addon-actions README

5a4d228

fix: update addons package.json

fce5cd0

fix: update "storybookhq" typos

a712ab5

aaronmcadam requested a review from ndelangen May 7, 2017 23:29

ndelangen reviewed May 8, 2017

View reviewed changes

Merge branch 'master' into am-change-npm-organisation

13f9c48

ndelangen added this to the v3.0.0 milestone May 10, 2017

ndelangen added the discussion label May 10, 2017

usulpro added the maintenance User-facing maintenance tasks label May 12, 2017

ndelangen added 5 commits May 14, 2017 21:40

CHANGE folder structure && CHANGE package-names

69b91f6

RESET codemod

c1b7e30

RENAME decorator-cantered to addon-centered

bd95b6e

Merge pull request #1031 from storybooks/change-packagenames-folderst…

747dc70

…ructure CHANGE folder structure && CHANGE package-names

ndelangen removed the discussion label May 15, 2017

ndelangen added 6 commits May 16, 2017 07:47

REMOVE track_usage

32a530c

Single source of truth for LICENCE for all packages

51ad5d5

UPDATE readmes

991edf3

CLEANUP

e2c7a9c

FIX linting

36c7ca7

ADD .bithoundrc

bcbc570

ndelangen merged commit a9944e1 into master May 16, 2017

ndelangen removed the in progress label May 16, 2017

shilman added a commit to shilman/storybook that referenced this pull request May 17, 2017

Update to new package structure

598fd65

See: storybookjs#996

ajhyndman mentioned this pull request May 17, 2017

Update README #1042

Closed

shilman mentioned this pull request May 18, 2017

3.0.0 release notes && release notes automation #1047

Merged

ndelangen pushed a commit that referenced this pull request May 24, 2017

Update to new package structure

02c24d4

See: #996

ndelangen changed the title ~~refactor: change NPM organisation from kadira to storybook~~ change NPM organisation from kadira to storybook in code May 27, 2017

Hypnosphi deleted the am-change-npm-organisation branch August 17, 2017 22:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

change NPM organisation from kadira to storybook in code #996

change NPM organisation from kadira to storybook in code #996

aaronmcadam commented May 6, 2017 •

edited by ndelangen

Loading

codecov bot commented May 6, 2017 •

edited

Loading

aaronmcadam commented May 6, 2017

ndelangen left a comment

ndelangen commented May 8, 2017

aaronmcadam commented May 8, 2017 via email

aaronmcadam commented May 8, 2017

ndelangen commented May 8, 2017 •

edited

Loading

ndelangen commented May 9, 2017

aaronmcadam commented May 9, 2017

aaronmcadam commented May 9, 2017 •

edited

Loading

usulpro commented May 9, 2017 •

edited

Loading

ndelangen commented May 9, 2017

ndelangen commented May 9, 2017

theinterned commented May 9, 2017

aaronmcadam commented May 9, 2017

aaronmcadam commented May 10, 2017 •

edited

Loading

ndelangen commented May 10, 2017 •

edited by aaronmcadam

Loading

aaronmcadam commented May 10, 2017

usulpro commented May 10, 2017

aaronmcadam commented May 10, 2017

usulpro commented May 12, 2017

nx-cloud bot commented Jul 23, 2024

change NPM organisation from kadira to storybook in code #996

change NPM organisation from kadira to storybook in code #996

Conversation

aaronmcadam commented May 6, 2017 • edited by ndelangen Loading

Blocked by

What I did

How to test

TODO

New Package directories and names

codecov bot commented May 6, 2017 • edited Loading

Codecov Report

aaronmcadam commented May 6, 2017

ndelangen left a comment

Choose a reason for hiding this comment

ndelangen commented May 8, 2017

aaronmcadam commented May 8, 2017 via email

aaronmcadam commented May 8, 2017

ndelangen commented May 8, 2017 • edited Loading

ndelangen commented May 9, 2017

aaronmcadam commented May 9, 2017

aaronmcadam commented May 9, 2017 • edited Loading

usulpro commented May 9, 2017 • edited Loading

ndelangen commented May 9, 2017

ndelangen commented May 9, 2017

theinterned commented May 9, 2017

aaronmcadam commented May 9, 2017

aaronmcadam commented May 10, 2017 • edited Loading

ndelangen commented May 10, 2017 • edited by aaronmcadam Loading

aaronmcadam commented May 10, 2017

usulpro commented May 10, 2017

aaronmcadam commented May 10, 2017

usulpro commented May 12, 2017

nx-cloud bot commented Jul 23, 2024

☁️ Nx Cloud Report

aaronmcadam commented May 6, 2017 •

edited by ndelangen

Loading

codecov bot commented May 6, 2017 •

edited

Loading

ndelangen commented May 8, 2017 •

edited

Loading

aaronmcadam commented May 9, 2017 •

edited

Loading

usulpro commented May 9, 2017 •

edited

Loading

aaronmcadam commented May 10, 2017 •

edited

Loading

ndelangen commented May 10, 2017 •

edited by aaronmcadam

Loading