Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for math/base/special/fibonacci-index #2272

Merged
merged 2 commits into from
May 29, 2024
Merged

feat: add C implementation for math/base/special/fibonacci-index #2272

merged 2 commits into from
May 29, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented May 28, 2024 •
edited
Loading

Description

What is the purpose of this pull request?

This pull request:

double stdlib_base_fibonacci_index( const double x )

Related Issues

Does this pull request have any related issues?

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers
@Planeshifter

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label May 28, 2024
@Planeshifter Planeshifter self-requested a review May 28, 2024 17:52
Planeshifter
Planeshifter approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean and should be ready to land.

@Planeshifter
Update lib/node_modules/@stdlib/math/base/special/fibonacci-index/src…
738aab8 
…/main.c

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter Planeshifter merged commit 1ba660a into stdlib-js:develop May 29, 2024
8 checks passed
@gunjjoshi gunjjoshi deleted the fibonacci-index branch June 11, 2024 03:12
@gunjjoshi gunjjoshi mentioned this pull request Jul 27, 2024
Closed
3 tasks
@kgryte kgryte mentioned this pull request Jul 27, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gunjjoshi @Planeshifter @stdlib-bot