[RFC]: Add C implementation for @stdlib/math/base/special/fibonacci-index

[tudor-pagu]

Description

This RFC proposes adding native C implementation for @stdlib/math/base/special/fibonacci-index.

double stdlib_base_fibonacci_index( const double F );

Related Issues

Tracked in issue #649.

Questions

I am not sure about the method's signature. In the original JavaScript code, both the return type and the parameter are {NonNegativeInteger}. However, in some tests they take on the value NaN, which as far as I know does not exist for integer types in C. For this reason, I decided on using double, but please tell me if there is a more suitable solution.

Other

The implementation depends on the round function, which is addressed in #735. I can use the round method from C until the method is implemented in stdlib, and I can also contribute to implementing round.

Checklist

• I have read and understood the Code of Conduct.
• Searched for existing issues and pull requests.
• The issue name begins with RFC:.

[stdlib-bot]

👋 Hi there! 👋

And thank you for opening your first issue! We will get back to you shortly. 🏃 💨

[tudor-pagu]

Hi @kgryte @Planeshifter @Pranavchiku, I would like to work on this issue, could it please be assigned to me?

[kgryte]

@tudor-pagu We cannot use C round as it's behavior diverges from JS's behavior. This RFC is blocked until we can get #735 over the finish line.

[vivek-anand-singh]

Since #735 issue is closed now. Can you please assign this to me @kgryte @Pranavchiku

[kgryte]

@vivek-anand-singh Yes, assigned. Thanks for volunteering to work on this.

[gunjjoshi]

@kgryte We can close this issue, as it is completed by #2272.

[kgryte]

Thanks, @gunjjoshi, for following up here.