Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update math/base/special/log2 to follow FreeBSD version 12.2.0 #2172

Merged
merged 3 commits into from
Apr 16, 2024
Merged

refactor: update math/base/special/log2 to follow FreeBSD version 12.2.0 #2172

merged 3 commits into from
Apr 16, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Apr 15, 2024 •
edited
Loading

Resolves #2170.

Description

What is the purpose of this pull request?

This pull request:

  • updates existing C and JavaScript implementations to follow FreeBSD version 12.2.0.
  • adds corresponding tests
  • removed klog.js and related files, instead used kernelLog1p.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Apr 15, 2024
@kgryte kgryte changed the title refactor math/base/special/log2 to follow FreeBSD version 12.2.0 refactor: update math/base/special/log2 to follow FreeBSD version 12.2.0 Apr 16, 2024
kgryte
kgryte approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @gunjjoshi!

@kgryte kgryte merged commit be5ece8 into stdlib-js:develop Apr 16, 2024
6 checks passed
@gunjjoshi gunjjoshi deleted the log2 branch April 16, 2024 05:33
@gunjjoshi gunjjoshi mentioned this pull request Apr 28, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor math/base/special/log2 to follow FreeBSD version 12.2.0
3 participants
@gunjjoshi @kgryte @stdlib-bot