Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: refactor math/base/special/log2 to follow FreeBSD version 12.2.0 #2170

Closed
3 tasks done
gunjjoshi opened this issue Apr 15, 2024 · 1 comment · Fixed by #2172
Closed
3 tasks done

[RFC]: refactor math/base/special/log2 to follow FreeBSD version 12.2.0 #2170

gunjjoshi opened this issue Apr 15, 2024 · 1 comment · Fixed by #2172
Labels
Accepted RFC feature request which has been accepted. Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality.

Comments

@gunjjoshi
Copy link
Member

Description

This RFC proposes refactoring math/base/special/log2 based on FreeBSD version 12.2.0, instead of the current 9.3.0.

This comes after we added a separate package for kernel-log1p at #2144, which eliminates the need to rewrite the klog function for log2. As we have implemented kernelLog1p based on FreeBSD 12.2.0, log2 must also be refactored to follow the same version, which has a bit different implementation.

Tested locally, having 12.2.0 version implementations for both kernelLog1p and log2 provide way better precision, as compared to having 12.2.0 for kernelLog1p and 9.3.0 for log2.

References:

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@gunjjoshi
Copy link
Member Author

I'd like to work on this.

@gunjjoshi gunjjoshi mentioned this issue Apr 15, 2024
Merged
1 task
@kgryte kgryte added Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality. Accepted RFC feature request which has been accepted. labels Apr 16, 2024
kgryte added a commit that referenced this issue Apr 16, 2024
@gunjjoshi @kgryte
refactor: update math/base/special/log2 implementation
be5ece8 
PR-URL: #2172
Closes: #2170 
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted RFC feature request which has been accepted. Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: update math/base/special/log2 to follow FreeBSD version 12.2.0
2 participants
@kgryte @gunjjoshi