Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Movies UI to v2.5 #397

Merged
merged 15 commits into from
Mar 20, 2020
Merged

Conversation

WithoutPants
Copy link
Collaborator

Ported the Movies UI to the 2.5 UI.

@WithoutPants WithoutPants added this to the Version 0.2.0 milestone Mar 13, 2020
@bnkai
Copy link
Collaborator

bnkai commented Mar 13, 2020

I'm getting a something is wrong error as soon as i click a movie e.g. http://localhost:9998/movies/1
the full error from the inspector

TypeError: "ye is undefined"
    el Movie.tsx:105
    React 7
        la
        Wa
        Ec
        vs
        ps
        os
        Gi
    unstable_runWithPriority scheduler.production.min.js:18
    React 5
        qi
        Gi
        Wi
        es
        ka
    next QueryData.ts:282
    g Observable.js:135
    O Observable.js:179
    value Observable.js:235
    g ObservableQuery.ts:701
    g ObservableQuery.ts:701
    next ObservableQuery.ts:662
    i QueryManager.ts:518
    queryListenerForObserver QueryManager.ts:644
    broadcastQueries QueryManager.ts:1091
    broadcastQueries QueryManager.ts:1087
    broadcastQueries QueryManager.ts:1085
    g QueryManager.ts:1237
    next Observable.js:322
    g Observable.js:135
    O Observable.js:179
    value Observable.js:235
    next observables.ts:12
    next observables.ts:12
    g Observable.js:135
    O Observable.js:179
    value Observable.js:235
    f httpLink.ts:142
react-dom.production.min.js:196:194
    React 5
        fc
        callback
        Oo
        go
        gs
    unstable_runWithPriority scheduler.production.min.js:18
    React 4
        qi
        bs
        os
        Gi
    unstable_runWithPriority scheduler.production.min.js:18
    React 5
        qi
        Gi
        Wi
        es
        ka
    next QueryData.ts:282
    g Observable.js:135
    O Observable.js:179
    value Observable.js:235
    g ObservableQuery.ts:701
    g ObservableQuery.ts:701
    next ObservableQuery.ts:662
    i QueryManager.ts:518
    queryListenerForObserver QueryManager.ts:644
    broadcastQueries QueryManager.ts:1091
    broadcastQueries QueryManager.ts:1087
    broadcastQueries QueryManager.ts:1085
    g QueryManager.ts:1237
    next Observable.js:322
    g Observable.js:135
    O Observable.js:179
    value Observable.js:235
    next observables.ts:12
    next observables.ts:12
    g Observable.js:135
    O Observable.js:179
    value Observable.js:235
    f httpLink.ts:142​

@WithoutPants
Copy link
Collaborator Author

Dumb mistake trying to fix a linting issue. Fixed.

@bnkai
Copy link
Collaborator

bnkai commented Mar 13, 2020

a small glitch when you add a new movie and type in the name field
doublename
the movie name is shown doubled to the left above the "Name" part

@bnkai
Copy link
Collaborator

bnkai commented Mar 13, 2020

lol it was the placeholders for the covers nvm

@bnkai
Copy link
Collaborator

bnkai commented Mar 13, 2020

The Movies/Scenes , Scene Index functionality is missing from the Scene -> Edit panel ( scenes cannot be added to movies )

@WithoutPants
Copy link
Collaborator Author

Added the missing scene/movie relationship functionality.

@bnkai
Copy link
Collaborator

bnkai commented Mar 17, 2020

Everything works ok for me.
The only glitch is the movies synopsis for me as it is still too small imo.

Can we take it out of the table so that it takes the whole area (doubling the width) ?
The title part of it takes space that can be better used for the synopsis and maybe even the url.
Switching to title above data (instead of left) also makes for room for the synopsis / url.

@WithoutPants WithoutPants added the feature Pull requests that add a new feature label Mar 20, 2020
@WithoutPants
Copy link
Collaborator Author

Moved URL and synopsis to their own rows.

Copy link
Collaborator

@bnkai bnkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

@WithoutPants WithoutPants merged commit ff49536 into stashapp:develop Mar 20, 2020
Tweeticoats pushed a commit to Tweeticoats/stash that referenced this pull request Feb 1, 2021
* Ignore generated-graphql.tsx in 2.5
* Make movie name mandatory
* Port stashapp#395 fix to v2.5
* Differentiate front/back image browse buttons
* Move URL, Synopsis to separate rows
* Fix unknown query params crashing UI
@WithoutPants WithoutPants deleted the movies-2.5 branch February 4, 2021 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull requests that add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants