Fix error when viewing scenes related to objects with illegal characters in name #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WithoutPants
changed the title
ghost
reviewed
Mar 13, 2020
Comment on lines
26
to
29
| const ret = { ...o }; | ||
| ret.label = encodeURIComponent(o.label); | ||
| return ret; | ||
| } |
There was a problem hiding this comment.
You can just do return { ...o, label: encodeURIComponent(o.label) }. Properties are set in the order they are passed in, so even if o has a label, it will be overwrittenby encodeURIComponent.
bnkai
approved these changes
Mar 13, 2020
WithoutPants
added a commit
to WithoutPants/stash
that referenced
this pull request
Mar 13, 2020
WithoutPants
added a commit
that referenced
this pull request
Mar 20, 2020
* Ignore generated-graphql.tsx in 2.5 * Make movie name mandatory * Port #395 fix to v2.5 * Differentiate front/back image browse buttons * Move URL, Synopsis to separate rows * Fix unknown query params crashing UI
Tweeticoats
pushed a commit
to Tweeticoats/stash
that referenced
this pull request
Feb 1, 2021
…ers in name (stashapp#395) * Fix gitattributes for v2.5
Tweeticoats
pushed a commit
to Tweeticoats/stash
that referenced
this pull request
Feb 1, 2021
* Ignore generated-graphql.tsx in 2.5 * Make movie name mandatory * Port stashapp#395 fix to v2.5 * Differentiate front/back image browse buttons * Move URL, Synopsis to separate rows * Fix unknown query params crashing UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #394
Encodes
ILabeledIdobjects so that illegal characters (#;,/?:@&=+$) don't break the query URL parsing.Tested by creating Movies, Studios, Performers and tags with illegal characters in the names, then clicking on the query link on the relevant page. Change has been ported to UI v2.5 except for Movies, since that is not yet in 2.5.
Also includes linting and format changes for 2.5.