This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(mixed): avoid usages of global document and window
#1970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
force-pushed
the
fix/document-usage-in-components
branch
from
6b6871a
to
6ac9f5b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1970 +/- ##
=========================================
+ Coverage 70.29% 70.3% +0.01%
=========================================
Files 894 894
Lines 7901 7905 +4
Branches 2313 2291 -22
=========================================
+ Hits 5554 5558 +4
Misses 2334 2334
Partials 13 13
Continue to review full report at Codecov.
|
…ps://github.com/stardust-ui/react into fix/document-usage-in-components
layershifter
commented
Sep 25, 2019
| }, | ||
| "rules": { | ||
| "no-undef": "error" | ||
| } |
There was a problem hiding this comment.
Temporary solution until we will merge #1963.
layershifter
commented
Sep 25, 2019
| "files": "src/**/*.{ts,tsx}", | ||
| "globals": { | ||
| "document": "off", | ||
| "window": "off" |
There was a problem hiding this comment.
It's reasonable to disable only document and window globals as they are context dependent.
layershifter
commented
Sep 25, 2019
| @@ -273,7 +273,9 @@ export default class Popup extends AutoControlledComponent<PopupProps, PopupStat | |||
| const lastContentRef = getRefs().pop() | |||
| const isLastOpenedPopup: boolean = | |||
| lastContentRef && lastContentRef.current === this.popupDomElement | |||
| const bodyHasFocus: boolean = document.activeElement === document.body | |||
|
|
|||
| const activeDocument = this.props.mountDocument || this.context.target | |||
There was a problem hiding this comment.
We need to consider remove mountDocument prop from Popup at all.
layershifter
commented
Sep 25, 2019
| } | ||
| this.animationFrameId = window.requestAnimationFrame(() => { | ||
|
|
||
| this.animationFrameId = requestAnimationFrame(() => { |
There was a problem hiding this comment.
Discussed with @miroslavstastny, there are no reasons to use it from window
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
jurokapsiar
approved these changes
Sep 25, 2019
layershifter
added a commit
that referenced
this pull request
Sep 26, 2019
Merged
layershifter
added a commit
that referenced
this pull request
Oct 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1964.
This PR removes remaining usages of
documentandwindowglobals in components. Also forces ESLint to catch such issues.