Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

Remove usage of global document and window from components #1964

Closed
jurokapsiar opened this issue Sep 24, 2019 · 1 comment · Fixed by #1970
Closed

Remove usage of global document and window from components #1964

jurokapsiar opened this issue Sep 24, 2019 · 1 comment · Fixed by #1970
Labels
vsts Paired with ticket in vsts

Comments

@jurokapsiar
Copy link
Contributor

Bug Report

Following components still contain references to global document/window:

  • Dropdown.tsx line 814
  • Loader.tsx line 105
  • Popup.tsx line 276
  • Toolbar.tsx lines 182, 189, 191
  • ToolbarRadioGroup.tsx line 103

Also, check focusUtilities, lines 430 and 440 which also use the globals, but just as a fallback value.

Version

0.39.0
@layershifter
Copy link
Member

Linking #1963 as it contains all failures.

@pkumarie2011 pkumarie2011 added the vsts Paired with ticket in vsts label Sep 24, 2019
@layershifter layershifter mentioned this issue Sep 25, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
vsts Paired with ticket in vsts
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(mixed): avoid usages of global document and window microsoft/fluent-ui-react
3 participants
@jurokapsiar @layershifter @pkumarie2011