Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

chore(eslint): disable browser globals #1963

Closed
wants to merge 2 commits into from
Closed

chore(eslint): disable browser globals #1963

wants to merge 2 commits into from

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Sep 24, 2019 •
edited
Loading

Also enable:

  "react-hooks/rules-of-hooks": "error",
    "react-hooks/exhaustive-deps": "warn"

This was referenced Sep 24, 2019
Closed
Merged
@layershifter
Copy link
Member Author

Actually I am not sure that we need to disable globals for everything.
We have already disabled them for packages/react and I think that this is enough for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@levithomason levithomason Awaiting requested review from levithomason levithomason will be requested when the pull request is marked ready for review levithomason is a code owner

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny miroslavstastny will be requested when the pull request is marked ready for review miroslavstastny is a code owner

@kenotron kenotron Awaiting requested review from kenotron kenotron will be requested when the pull request is marked ready for review kenotron is a code owner

@ecraig12345 ecraig12345 Awaiting requested review from ecraig12345 ecraig12345 will be requested when the pull request is marked ready for review ecraig12345 is a code owner

@dzearing dzearing Awaiting requested review from dzearing dzearing will be requested when the pull request is marked ready for review dzearing is a code owner

@JasonGore JasonGore Awaiting requested review from JasonGore JasonGore will be requested when the pull request is marked ready for review JasonGore is a code owner

Assignees
No one assigned
Labels
🗑️ chore 🚧 WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@layershifter