Delete model metadata from schema_*.yaml #2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yifanmai
requested review from
percyliang,
teetone and
JosselinSomervilleRoberts
percyliang
reviewed
Jan 4, 2024
| @@ -1321,6 +1369,7 @@ def run_pipeline(self, skip_completed: bool, num_instances: int) -> None: | |||
| self.read_overlap_stats() | |||
|
|
|||
| self.write_executive_summary() | |||
| self.write_schema() | |||
There was a problem hiding this comment.
Is there any reason this is moved down?
There was a problem hiding this comment.
Yes, write_schema() now needs to go after read_runs(), because the runs are now needed to filter out the models that get written to the schema.
Eventually, it would be good to do a refactor to change all the instance variables to local variables, which will make the inputs and outputs of each step more clear.
There was a problem hiding this comment.
Got it. Maybe leave a comment?
There was a problem hiding this comment.
Sure, added a comment.
percyliang
approved these changes
Jan 4, 2024
|
Drive by addressing #2197 which is breaking CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, model metadata is duplicated across three files (
schema_classic.yaml,schema_lite.yaml,model_metadata.yaml). This makes it difficult to keep model metadata up to date.Additionally, the frontend currently displays metadata for every model, instead of only models that are available.
This deletes models from
schema_classic.yamlandschema_lite.yaml. Model metadata should only be stored inmodel_metadata.yaml.Additionally, this changes
helm-summarizeto only write model metadata from models that were actually used in the suite to the frontend JSON. For instance, this prevents HEIM or VHELM models from showing up on the HELM Lite sub-site.Also addresses #2197 to make CI pass, by pinning
opencv-python==4.9.0.80.