Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadtheDocs build is failing with new model deployment changes #2208

Closed
teetone opened this issue Jan 8, 2024 · 3 comments
Closed

ReadtheDocs build is failing with new model deployment changes #2208

teetone opened this issue Jan 8, 2024 · 3 comments
Assignees
Labels
devinfra models p1 Priority 1 (Required for release)

Comments

@teetone
Copy link
Member

teetone commented Jan 8, 2024

mkdocs_macros.py has failures:

INFO     -  [macros] - Macros arguments: {'module_name': 'docs/mkdocs_macros', 'modules': [], 'include_dir': '', 'include_yaml': [], 'j2_block_start_string': '', 'j2_block_end_string': '', 'j2_variable_start_string': '', 'j2_variable_end_string': '', 'on_undefined': 'keep', 'on_error_fail': False, 'verbose': False}
Traceback (most recent call last):
  File "/home/docs/.asdf/installs/python/3.8.18/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/home/docs/.asdf/installs/python/3.8.18/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/home/docs/checkouts/readthedocs.org/user_builds/crfm-helm/envs/latest/lib/python3.8/site-packages/mkdocs/__main__.py", line 301, in <module>
    cli()
  File "/home/docs/checkouts/readthedocs.org/user_builds/crfm-helm/envs/latest/lib/python3.8/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/home/docs/checkouts/readthedocs.org/user_builds/crfm-helm/envs/latest/lib/python3.8/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/home/docs/checkouts/readthedocs.org/user_builds/crfm-helm/envs/latest/lib/python3.8/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/docs/checkouts/readthedocs.org/user_builds/crfm-helm/envs/latest/lib/python3.8/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/docs/checkouts/readthedocs.org/user_builds/crfm-helm/envs/latest/lib/python3.8/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/home/docs/checkouts/readthedocs.org/user_builds/crfm-helm/envs/latest/lib/python3.8/site-packages/mkdocs/__main__.py", line 250, in build_command
    build.build(cfg, dirty=not clean)
  File "/home/docs/checkouts/readthedocs.org/user_builds/crfm-helm/envs/latest/lib/python3.8/site-packages/mkdocs/commands/build.py", line 270, in build
    config = config.plugins.run_event('config', config)
  File "/home/docs/checkouts/readthedocs.org/user_builds/crfm-helm/envs/latest/lib/python3.8/site-packages/mkdocs/plugins.py", line 520, in run_event
    result = method(item, **kwargs)
  File "/home/docs/checkouts/readthedocs.org/user_builds/crfm-helm/envs/latest/lib/python3.8/site-packages/mkdocs_macros/plugin.py", line 554, in on_config
    self._load_modules()
  File "/home/docs/checkouts/readthedocs.org/user_builds/crfm-helm/envs/latest/lib/python3.8/site-packages/mkdocs_macros/plugin.py", line 431, in _load_modules
    module = import_local_module(self.project_dir, local_module_name)
  File "/home/docs/checkouts/readthedocs.org/user_builds/crfm-helm/envs/latest/lib/python3.8/site-packages/mkdocs_macros/util.py", line 131, in import_local_module
    spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 843, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/docs/checkouts/readthedocs.org/user_builds/crfm-helm/checkouts/latest/docs/mkdocs_macros.py", line 5, in <module>
    from helm.benchmark.presentation.schema import read_schema, SCHEMA_CLASSIC_YAML_FILENAME, ModelField
ImportError: cannot import name 'ModelField' from 'helm.benchmark.presentation.schema' (/home/docs/checkouts/readthedocs.org/user_builds/crfm-helm/envs/latest/lib/python3.8/site-packages/helm/benchmark/presentation/schema.py)
@teetone teetone added the p1 Priority 1 (Required for release) label Jan 8, 2024
@JosselinSomervilleRoberts
Copy link
Contributor

I think this was caused by #2195 ?

@yifanmai
Copy link
Collaborator

yifanmai commented Jan 8, 2024

That seems likely. Reassigning to myself.

@yifanmai
Copy link
Collaborator

yifanmai commented Jan 9, 2024

Fixed by #2214.

@yifanmai yifanmai closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devinfra models p1 Priority 1 (Required for release)
Projects
None yet
Development

No branches or pull requests

3 participants