Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laplace sampling: change output columns for consistency #3184

Merged
merged 2 commits into from
Apr 28, 2023

Conversation

WardBrian
Copy link
Member

Submission Checklist

  • Run unit tests: ./runTests.py src/test/unit
  • Run cpplint: make cpplint
  • Declare copyright holder and open-source license: see below

Summary

Closes #3183. This changes the names of the log_p and log_q output columns to log_p__ and log_q__, and moves them to the start to match up with other algorithms.

Unfortunately this was not caught before release, but because cmdstanpy and cmdstanr don't have support for this built-out yet I think we can say that it is a bug fix rather than a breaking change, and release it in 2.32.1 next week (see stan-dev/cmdstan#1154)

I believe the CmdStan implementation also assumes this ordering in its tests, so those may briefly break if we merge this.

Documentation

The docs page (https://mc-stan.org/docs/cmdstan-guide/laplace-sampling.html) will need to be updated

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Copy link
Member

@mitzimorris mitzimorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Laplace sampling service output is inconsistent with other services.
3 participants