Laplace sampling: change output columns for consistency #3184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
./runTests.py src/test/unit
make cpplint
Summary
Closes #3183. This changes the names of the
log_p
andlog_q
output columns tolog_p__
andlog_q__
, and moves them to the start to match up with other algorithms.Unfortunately this was not caught before release, but because cmdstanpy and cmdstanr don't have support for this built-out yet I think we can say that it is a bug fix rather than a breaking change, and release it in 2.32.1 next week (see stan-dev/cmdstan#1154)
I believe the CmdStan implementation also assumes this ordering in its tests, so those may briefly break if we merge this.
Documentation
The docs page (https://mc-stan.org/docs/cmdstan-guide/laplace-sampling.html) will need to be updated
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: