Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laplace sampling service output is inconsistent with other services. #3183

Closed
WardBrian opened this issue Apr 28, 2023 · 0 comments · Fixed by #3184
Closed

Laplace sampling service output is inconsistent with other services. #3183

WardBrian opened this issue Apr 28, 2023 · 0 comments · Fixed by #3184

Comments

@WardBrian
Copy link
Member

WardBrian commented Apr 28, 2023 •
edited
Loading

The laplace service method added in #3148 produces a CSV file where the final two columns are log_p and log_q. This has two issues:

  1. All other services have "algorithmic parameters" (e.g. lp__ for sampling, log_g__ for ADVI) output before the model's parameters
  2. These names are not suffixed with the usual two underscores, which means a user can write a model with a parameter named log_p and receive a confounding CSV header which many libraries will refuse to parse:
log_p,log_p,log_q
0.281593,-6.77835,-0.194159

Current Version:

v2.32.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Laplace sampling: change output columns for consistency stan-dev/stan
1 participant
@WardBrian