Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move JSON parser from CmdStan to Stan/io #3143

Merged
merged 6 commits into from
Sep 27, 2022
Merged

Conversation

WardBrian
Copy link
Member

Submission Checklist

  • Run unit tests: ./runTests.py src/test/unit
  • Run cpplint: make cpplint
  • Declare copyright holder and open-source license: see below

Summary

This is the first half of #3142 and undoes #2803

Intended Effect

Move the JSON parser code from cmdstan to this repo. Tests are also moved.

How to Verify

Side Effects

Documentation

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@bob-carpenter
Copy link
Contributor

I can review this when it's ready as long as that's today or early tomorrow or some time later this week.

@WardBrian
Copy link
Member Author

@bob-carpenter this should be ready as-is; it's just a copy-paste job with some renaming of namespaces.

Copy link
Contributor

@bob-carpenter bob-carpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. the renaming and updates to make all look good.

@WardBrian
Copy link
Member Author

I'm going to let the CI here and stan-dev/cmdstan#1120 finish before merging

@rok-cesnovar
Copy link
Member

The upstream tests fail because the CmdStan PR was merged, but since all other tests pass feel free to merge.

@WardBrian
Copy link
Member Author

@rok-cesnovar will that prevent the bot from updating the sub modules?

@WardBrian WardBrian merged commit f52c87f into develop Sep 27, 2022
@rok-cesnovar
Copy link
Member

I think it should be fine. The test that failed doesnt run on develop I believe.

@WardBrian WardBrian deleted the feature/move-json-parser branch September 27, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants