Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JSON parser code from Stan #2803

Merged
merged 3 commits into from
Oct 9, 2019
Merged

Remove JSON parser code from Stan #2803

merged 3 commits into from
Oct 9, 2019

Conversation

rok-cesnovar
Copy link
Member

Summary

Removes the files that were moved to cmdstan in stan-dev/cmdstan#726

This should be merged after the cmdstan PR is merged.

How to Verify

/

Side Effects

/

Documentation

/

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Rok Češnovar, University of Ljubljana

@rok-cesnovar rok-cesnovar mentioned this pull request Aug 26, 2019
Closed
@rok-cesnovar rok-cesnovar mentioned this pull request Sep 17, 2019
Closed
@seantalts
Copy link
Member

Would you mind resolving the conflicts?

@rok-cesnovar
Merge branch 'develop' into feature/move-json-io-to-cmdstan
ba34c2c 
# Conflicts:
#	src/stan/io/json/json_data.hpp
#	src/stan/io/json/json_data_handler.hpp
#	src/stan/io/json/json_error.hpp
#	src/stan/io/json/json_handler.hpp
#	src/stan/io/json/json_parser.hpp
#	src/test/unit/io/json/json_data_handler_test.cpp
#	src/test/unit/io/json/json_data_test.cpp
#	src/test/unit/io/json/json_parser_test.cpp
@rok-cesnovar
Copy link
Member Author

Done, thank you for notifying me.

@rok-cesnovar
Copy link
Member Author

The move was done on cmdstan end so these files can now safely be removed.

@stan-buildbot
Copy link
Contributor

(stat_comp_benchmarks/benchmarks/gp_pois_regr/gp_pois_regr.stan, 0.99)
(stat_comp_benchmarks/benchmarks/low_dim_corr_gauss/low_dim_corr_gauss.stan, 0.97)
(stat_comp_benchmarks/benchmarks/irt_2pl/irt_2pl.stan, 1.0)
(stat_comp_benchmarks/benchmarks/pkpd/one_comp_mm_elim_abs.stan, 1.0)
(stat_comp_benchmarks/benchmarks/eight_schools/eight_schools.stan, 1.0)
(stat_comp_benchmarks/benchmarks/gp_regr/gp_regr.stan, 1.01)
(stat_comp_benchmarks/benchmarks/arK/arK.stan, 1.0)
(performance.compilation, 1.04)
(stat_comp_benchmarks/benchmarks/low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan, 0.98)
(stat_comp_benchmarks/benchmarks/low_dim_gauss_mix/low_dim_gauss_mix.stan, 1.0)
(stat_comp_benchmarks/benchmarks/sir/sir.stan, 1.0)
(stat_comp_benchmarks/benchmarks/pkpd/sim_one_comp_mm_elim_abs.stan, 1.0)
(stat_comp_benchmarks/benchmarks/garch/garch.stan, 1.0)
(stat_comp_benchmarks/benchmarks/gp_regr/gen_gp_data.stan, 1.01)
(stat_comp_benchmarks/benchmarks/arma/arma.stan, 0.95)
Result: 0.99712890360
Commit hash: 8477d1d

@rok-cesnovar
Copy link
Member Author

Bumping this one, if anyone has time to review. This just removes 2500 lines by deleting the unused parser.

@SteveBronder
Copy link
Collaborator

I'm not supposed to approve stuff here but @seantalts do you mind if I slam this one in? (Or just do it when you read this)

@rok-cesnovar
Copy link
Member Author

Not that huge of a hurry, but would like if it gets in 2.21.

mitzimorris
mitzimorris approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@mitzimorris mitzimorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

so happy to see this go!

@mitzimorris mitzimorris merged commit dc49d3c into develop Oct 9, 2019
@serban-nicusor-toptal serban-nicusor-toptal added this to the 2.20.0++ milestone Oct 18, 2019
@mcol mcol deleted the feature/move-json-io-to-cmdstan branch February 22, 2020 12:27
@WardBrian WardBrian mentioned this pull request Sep 26, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitzimorris mitzimorris mitzimorris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.21.0
Development

Successfully merging this pull request may close these issues.
6 participants
@rok-cesnovar @seantalts @stan-buildbot @SteveBronder @mitzimorris @serban-nicusor-toptal