Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DML statements to MockBigQuery #4759

Merged
merged 4 commits into from
Apr 4, 2023

Conversation

fallonchen
Copy link
Contributor

Fixes #4757

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #4759 (552d5ec) into main (7afc3a4) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head 552d5ec differs from pull request most recent head 065dc41. Consider uploading reports for the commit 065dc41 to get more accurate results

@@            Coverage Diff             @@
##             main    #4759      +/-   ##
==========================================
- Coverage   61.10%   61.07%   -0.03%     
==========================================
  Files         286      286              
  Lines       10547    10552       +5     
  Branches      760      763       +3     
==========================================
  Hits         6445     6445              
- Misses       4102     4107       +5     
Impacted Files Coverage Δ
...scala/com/spotify/scio/bigquery/MockBigQuery.scala 0.00% <0.00%> (ø)
...la/com/spotify/scio/bigquery/client/BigQuery.scala 21.66% <0.00%> (-0.37%) ⬇️
...la/com/spotify/scio/bigquery/client/QueryOps.scala 0.71% <ø> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@RustedBones RustedBones merged commit 5443440 into spotify:main Apr 4, 2023
@RustedBones
Copy link
Contributor

Thank you!

@fallonchen fallonchen deleted the fallon/mockbigquerydml branch April 4, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable MockBigQuery to support DML statements
2 participants