Add unit-test for non DML statement

spotify · Apr 4, 2023 · 065dc41 · 065dc41
1 parent 4f26fe7
commit 065dc41
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/scio-google-cloud-platform/src/it/scala/com/spotify/scio/bigquery/BigQueryIT.scala b/scio-google-cloud-platform/src/it/scala/com/spotify/scio/bigquery/BigQueryIT.scala
@@ -96,19 +96,23 @@ class BigQueryIT extends AnyFlatSpec with Matchers with BeforeAndAfterEach with
     val allRowsQuery = s"SELECT word, word_count FROM `$writableTableRef` LIMIT 10"
     val mbq = MockBigQuery()
     mbq.mockTable(writableTableRef).withData(MockBQData.inData)
-    val insertQuery = s"INSERT INTO `${writableTableRef}` (word, word_count) VALUES ('cat', 2)"
+    val insertQuery = s"INSERT INTO `$writableTableRef` (word, word_count) VALUES ('cat', 2)"
     mbq.runDML(insertQuery)
     mbq.queryResult(allRowsQuery) should contain theSameElementsAs MockBQData.expected ++ Seq(
       MockBQData.wordCount("cat", 2)
     )
-    val updateQuery = s"UPDATE `${writableTableRef}` SET word_count = 4 WHERE word = 'cat'"
+    val updateQuery = s"UPDATE `$writableTableRef` SET word_count = 4 WHERE word = 'cat'"
     mbq.runDML(updateQuery)
     mbq.queryResult(allRowsQuery) should contain theSameElementsAs MockBQData.expected ++ Seq(
       MockBQData.wordCount("cat", 4)
     )
-    val deleteQuery = s"DELETE FROM `${writableTableRef}` WHERE word = 'cat'"
+    val deleteQuery = s"DELETE FROM `$writableTableRef` WHERE word = 'cat'"
     mbq.runDML(deleteQuery)
     mbq.queryResult(allRowsQuery) should contain theSameElementsAs MockBQData.expected
+
+    an[IllegalArgumentException] shouldBe thrownBy {
+      mbq.runDML(allRowsQuery)
+    }
   }
 
   object MockBQWildcardData {

diff --git a/scio-google-cloud-platform/src/main/scala/com/spotify/scio/bigquery/client/QueryOps.scala b/scio-google-cloud-platform/src/main/scala/com/spotify/scio/bigquery/client/QueryOps.scala
@@ -39,7 +39,7 @@ private[client] object QueryOps {
 
   private val Priority = if (isInteractive) "INTERACTIVE" else "BATCH"
 
-  final private[scio] case class QueryJobConfig(
+  final private case class QueryJobConfig(
     sql: String,
     useLegacySql: Boolean,
     dryRun: Boolean = false,