Fix .m4a containers #453
Merged
Fix .m4a containers #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritiek
force-pushed
the
fix-incorrect-metadata-m4a
branch
from
904f708
to
741c3ed
Compare
ritiek
force-pushed
the
fix-incorrect-metadata-m4a
branch
from
741c3ed
to
a0847f1
Compare
linusg
approved these changes
Dec 25, 2018
3 tasks
This was referenced Jan 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #331 and #334.
It seems like YouTube hosts
.m4aaudio streams which have incorrect container. Even youtube-dl corrects this container with FFmpeg.I've done something similar here as well based on @Amit-L's suggestion. Thanks @Amit-L!