Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default convert dash files to normal mp4 files #458

Closed
1 of 4 tasks
razaqq opened this issue Jan 1, 2019 · 7 comments · Fixed by #459
Closed
1 of 4 tasks

default convert dash files to normal mp4 files #458

razaqq opened this issue Jan 1, 2019 · 7 comments · Fixed by #459
Labels
Bug Unexpected problem or unintended behavior that needs to be fixed
Milestone

Comments

@razaqq
Copy link

razaqq commented Jan 1, 2019

What is the purpose of your issue?

  • Bug
  • Feature Request
  • Question
  • Other

Description

quodlibet/mutagen#366

@ritiek
Copy link
Member

ritiek commented Jan 1, 2019

Thanks for the issue. This should probably be fixed on the master branch with #453, but I'll take a look just in case.

@ritiek ritiek added this to the v1.1.1 milestone Jan 2, 2019
@ritiek ritiek added the Bug Unexpected problem or unintended behavior that needs to be fixed label Jan 2, 2019
@ritiek
Copy link
Member

ritiek commented Jan 2, 2019

This should be fixed in v1.1.1.

@razaqq
Copy link
Author

razaqq commented Jan 3, 2019

Thanks!

@razaqq
Copy link
Author

razaqq commented Jan 7, 2019

Issue still exists. quodlibet/mutagen#366

@ritiek ritiek reopened this Jan 8, 2019
@ritiek ritiek modified the milestones: v1.1.1, v1.1.2 Jan 11, 2019
@ritiek
Copy link
Member

ritiek commented Jan 15, 2019

Is this still the case on master branch? This seems to have been fixed for me. I downloaded a track as .m4a:

$ spotdl -s "janji - heroes tonight" -o .m4a
INFO: Janji - Heroes Tonight (feat. Johnning) [Lyrics] (http://www.youtube.com/watch?v=7bI36Iu6M6s)
  2,483,539 Bytes [100.00%] received. Rate: [  59 KB/s].  ETA: [0 secs]
INFO: Correcting container in "Janji - Heroes Tonight.m4a"
INFO: Applying metadata

and got these results when checking the bitrate:

>>> import mutagen
>>> f = mutagen.File("Janji - Heroes Tonight.m4a")
>>> print("Length: {}s; Bitrate: {}; Sample Rate: {}; Bits per Sample: {}".format(f.info.length, f.info.bitrate, f.info.sample_rate, f.info.bits_per_sample))
Length: 208.95637188208616s; Bitrate: 93588; Sample Rate: 44100; Bits per Sample: 16

which seems the ideal behaviour to me?

@ritiek
Copy link
Member

ritiek commented Jan 15, 2019

If you were hitting #470 then it is now fixed on master branch.

@razaqq
Copy link
Author

razaqq commented Jan 16, 2019

ill check when i have time, but seems fine!

@ritiek ritiek closed this as completed Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Unexpected problem or unintended behavior that needs to be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants