Extend eoiu support to speed up route reconciliation of EVPN/fdbsyncd #1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prsunny - can you please review, thanks. |
prsunny
reviewed
May 27, 2021
| const uint32_t DEFAULT_EOIU_HOLD_INTERVAL = 3; | ||
|
|
||
| // Check if eoiu state reached by ipv4 ipv6 and evpn | ||
| static bool eoiuFlagsSet(Table &bgpStateTable) |
There was a problem hiding this comment.
It conveys as Flag set. Can you rename to isEoiuFlagsSet instead?
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Signed-off-by: Yong Zhao yozhao@microsoft.com
What I did
This PR aims to update the config command of Kdump (Linux kernel dump) mechanism.
How I did it
Before updating the value of a field in the table of KDUMP, we need decide whether the KDUMP table and corresponding field does exist in the table.
How to verify it
I verifies this on device str-msn2700-03 and unit test passed.
tests/kdump_test.py::TestKdump::test_config_kdump_disable PASSED
tests/kdump_test.py::TestKdump::test_config_kdump_enable PASSED
tests/kdump_test.py::TestKdump::test_config_kdump_memory PASSED
tests/kdump_test.py::TestKdump::test_config_kdump_num_dumps PASSED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Extend bgp eoiu support to speed up route reconciliation of EVPN/fdbsyncd
Why I did it
To make use of eoiu feature to speed up reconciliation of EVPN/fdbsyncd
How I verified it
Tested with warm-reboot with EVPN, IPV6 and IPv4 AF BGP peers setup
Details if related
more details in issue #1657