Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend bgp eoiu support to speed up route reconciliation of EVPN/fdbsyncd #1657

Open
nkelapur opened this issue Mar 2, 2021 · 3 comments
Open

Comments

@nkelapur
Copy link
Contributor

nkelapur commented Mar 2, 2021

bgp eoiu support was implemented to speed up route reconciliation.
Same support needs to be extended to EVPN AF and this needs to be used in fdbsyncd logic to help reconcile fdbsyncd quickly after warm-reboot

@nkelapur
Copy link
Contributor Author

nkelapur commented Mar 2, 2021

eoiu was implemented for ipv4 and ipv6 AF for fpmsyncd in #856

@anshuv-mfst
Copy link

Issue triage 3/17:
BRCM team (Adam Y) to look into the issue, thanks.

@adyeung
Copy link

adyeung commented Mar 19, 2021

The issue was filed to track the missing bgp eoiu support in fdbsyncd, nkelapur from BRCM will work on the change and submit pull request in the next few weeks

EdenGri pushed a commit to EdenGri/sonic-swss that referenced this issue Feb 28, 2022
…n the same remote physical interface (sonic-net#1657)

Scenario:
1- remote interface has 2 MACs on the same physical interface.
2- "show lldp table" command displays one entry for only one MAC address

Root cause:
"show lldp table" command uses lldpshow script to get, parse and display data from the lldp open source package
 (lldpctl script). lldpctl script returns a proper info about the 2 MACs but the issue is with the lldpshow script parser 
where it built a dictionary which its key is the local physical interface. Therefore when having 2 MACs, lldpctl will 
return 2 entries but the lldpshow parser will overwrite the first enrty.

Fix:
Change the key to be a string of "interface#MAC".
This will enable having 2 entries for 2 different MAC addresses.

In addition:
- update display_sum()-->get_summary_output() to return a string instead of printing it directly.
this to allow checking the returned value inside the new unit test.
- add a new unit test for this scenario.

Signed-off-by: Basim Shalata <basims@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants