-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cdb fw upgrade #308
Cdb fw upgrade #308
Conversation
- Description cdb1_chkstatus will crash when i2c NACK or timeout. - Motivation and Context I2C of transceiver might NACK or stretching when FW upgrade, assuming "None" means "CdbIsBusy" until timeout.
- Description Waiting a delay in "run_fw_image" to ensure it is really executed. Return a special package when get none in "get_module_fw_info". - Motivation and Context "run_fw_image" will be executed after a delay which according to run cmd, waiting the delay in "run_fw_image" to avoid aother cmd sent before it really executing. CDB cmds will maybe cause several seconds NACK or stretching on i2c bus depend on implementation of module vendor, handling this situation for compatible with different implementation.
- Description Using real length to replace fixed number in "block_write_epl" function. - Motivation and Context To avoid a wrong epl length used in module.
Could you please upload Unit Test logs?. |
It doesn't support to attach .XML file, please change the extension by yourself. |
@prgeor could you please review this PR?. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be better if you could get the UT logs done inside the switch.
@CliveNi can you check the code coverage failure |
Test : Creating "get_module_fw_info" test.
Done, attachment is new UT log. |
* [Cloudlight] QSFP-DD FW upgrade doesn't work (#257) - Description cdb1_chkstatus will crash when i2c NACK or timeout. - Motivation and Context I2C of transceiver might NACK or stretching when FW upgrade, assuming "None" means "CdbIsBusy" until timeout. * [Cloudlight] QSFP-DD FW upgrade doesn't work (#257) - Description Waiting a delay in "run_fw_image" to ensure it is really executed. Return a special package when get none in "get_module_fw_info". - Motivation and Context "run_fw_image" will be executed after a delay which according to run cmd, waiting the delay in "run_fw_image" to avoid aother cmd sent before it really executing. CDB cmds will maybe cause several seconds NACK or stretching on i2c bus depend on implementation of module vendor, handling this situation for compatible with different implementation. * [Cloudlight] QSFP-DD FW upgrade doesn't work (#257) - Description Using real length to replace fixed number in "block_write_epl" function. - Motivation and Context To avoid a wrong epl length used in module. * Update unit tests for cmis. Test : Creating "get_module_fw_info" test.
[Cloudlight] QSFP-DD FW upgrade doesn't work (#257)
Description
Motivation and Context