Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QSFP-DD FW upgrade doesn't work #257

Closed
aravindmani-1 opened this issue Jan 12, 2022 · 0 comments
Closed

QSFP-DD FW upgrade doesn't work #257

aravindmani-1 opened this issue Jan 12, 2022 · 0 comments
Assignees

Comments

@aravindmani-1
Copy link
Contributor

For the optics/AOC's supporting LPL, EEPROM FW upgrade is failing.

root@sonic:~# sfputil firmware download Ethernet0 /var/tmp/Dell_CDB_TRIAL_FW_Major_01_Minor_02_BuildNo_03.bin

CDB: Starting firmware download

CDB: firmware download failed! - status 112

root@sonic:~#

status 112 indicates that the payload length is wrong.

@prgeor prgeor self-assigned this Feb 2, 2022
CliveNi added a commit to CliveNi/sonic-platform-common that referenced this issue Sep 2, 2022
- Description
cdb1_chkstatus will crash when i2c NACK or timeout.

- Motivation and Context
I2C of transceiver might NACK or stretching when FW upgrade, assuming "None" means "CdbIsBusy" until timeout.
CliveNi added a commit to CliveNi/sonic-platform-common that referenced this issue Sep 2, 2022
- Description
Waiting a delay in "run_fw_image" to ensure it is really executed.
Return a special package when get none in "get_module_fw_info".

- Motivation and Context
"run_fw_image" will be executed after a delay which according to run cmd, waiting the delay in "run_fw_image" to avoid aother cmd sent before it really executing.
CDB cmds will maybe cause several seconds NACK or stretching on i2c bus depend on implementation of module vendor, handling this situation for compatible with different implementation.
CliveNi added a commit to CliveNi/sonic-platform-common that referenced this issue Sep 2, 2022
- Description
Using real length to replace fixed number in "block_write_epl" function.

- Motivation and Context
To avoid a wrong epl length used in module.
@CliveNi CliveNi mentioned this issue Sep 2, 2022
prgeor pushed a commit that referenced this issue Sep 23, 2022
* [Cloudlight] QSFP-DD FW upgrade doesn't work (#257)

- Description
cdb1_chkstatus will crash when i2c NACK or timeout.

- Motivation and Context
I2C of transceiver might NACK or stretching when FW upgrade, assuming "None" means "CdbIsBusy" until timeout.

* [Cloudlight] QSFP-DD FW upgrade doesn't work (#257)

- Description
Waiting a delay in "run_fw_image" to ensure it is really executed.
Return a special package when get none in "get_module_fw_info".

- Motivation and Context
"run_fw_image" will be executed after a delay which according to run cmd, waiting the delay in "run_fw_image" to avoid aother cmd sent before it really executing.
CDB cmds will maybe cause several seconds NACK or stretching on i2c bus depend on implementation of module vendor, handling this situation for compatible with different implementation.

* [Cloudlight] QSFP-DD FW upgrade doesn't work (#257)

- Description
Using real length to replace fixed number in "block_write_epl" function.

- Motivation and Context
To avoid a wrong epl length used in module.

* Update unit tests for cmis.

Test : Creating "get_module_fw_info" test.
yxieca pushed a commit that referenced this issue Mar 1, 2023
* [Cloudlight] QSFP-DD FW upgrade doesn't work (#257)

- Description
cdb1_chkstatus will crash when i2c NACK or timeout.

- Motivation and Context
I2C of transceiver might NACK or stretching when FW upgrade, assuming "None" means "CdbIsBusy" until timeout.

* [Cloudlight] QSFP-DD FW upgrade doesn't work (#257)

- Description
Waiting a delay in "run_fw_image" to ensure it is really executed.
Return a special package when get none in "get_module_fw_info".

- Motivation and Context
"run_fw_image" will be executed after a delay which according to run cmd, waiting the delay in "run_fw_image" to avoid aother cmd sent before it really executing.
CDB cmds will maybe cause several seconds NACK or stretching on i2c bus depend on implementation of module vendor, handling this situation for compatible with different implementation.

* [Cloudlight] QSFP-DD FW upgrade doesn't work (#257)

- Description
Using real length to replace fixed number in "block_write_epl" function.

- Motivation and Context
To avoid a wrong epl length used in module.

* Update unit tests for cmis.

Test : Creating "get_module_fw_info" test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants