[pytest] Skip testing the format of alerting message from Monit on 202012 image #3559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and newer image version. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
yozhao101
changed the title
yozhao101
changed the title
bingwang-ms
reviewed
Jun 1, 2021
bingwang-ms
approved these changes
Jun 1, 2021
skip testing the 202012 image. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
jleveque
approved these changes
Jun 1, 2021
|
This pull request introduces 1 alert when merging 7592f1c into e27602e - view on LGTM.com new alerts:
|
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
…2012 image (sonic-net#3559) What is the motivation for this PR? Since Supervisord will replace Monit to do the monitoring of critical processes, this test needs skip the testbeds which were installed with 202012 or newer image version. At the same time, this test needs handle the error if the command sudo monit status 'lldp|lldpmgrd' returns the non-zero exit code. I met the following error message when this PR (sonic-net/sonic-buildimage#7676) was tested on virtual testbed. monit/test_monit_status.py::test_monit_status[vlab-03] PASSED [ 50%] monit/test_monit_status.py::test_monit_reporting_message[vlab-03] -------------------------------- live log call --------------------------------- 02:11:26 utilities.wait_until L0068 ERROR | Exception caught while checking check_monit_last_output: IndexError('list index out of range',) 02:12:26 utilities.wait_until L0068 ERROR | Exception caught while checking check_monit_last_output: IndexError('list index out of range',) 02:13:27 utilities.wait_until L0068 ERROR | Exception caught while checking check_monit_last_output: IndexError('list index out of range',) FAILED How did you do it? I used the pytest_require(...) to skip the testbed which were installed 202012 or newer image version. How did you verify/test it? I verified this change on the testbed str-msn2700-03. Any platform specific information? N/A Supported testbed topology if it's a new test case? N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yong Zhao yozhao@microsoft.com
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
Since Supervisord will replace Monit to do the monitoring of critical processes, this test needs skip the testbeds which were installed with 202012 or newer image version. At the same time, this test needs handle the error if the command
sudo monit status 'lldp|lldpmgrd'returns the non-zero exit code.I met the following error message when this PR (sonic-net/sonic-buildimage#7676) was tested on virtual testbed.
How did you do it?
I used the
pytest_require(...)to skip the testbed which were installed 202012 or newer image version.How did you verify/test it?
I verified this change on the testbed
str-msn2700-03.Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation