[Monit] Deprecate the feature of monitoring the critical processes by Monit #7676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monit. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…toring_processes_monit
processes in streaming telemetry. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
3 tasks
yozhao101
added a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Jun 1, 2021
…2012 image (#3559) What is the motivation for this PR? Since Supervisord will replace Monit to do the monitoring of critical processes, this test needs skip the testbeds which were installed with 202012 or newer image version. At the same time, this test needs handle the error if the command sudo monit status 'lldp|lldpmgrd' returns the non-zero exit code. I met the following error message when this PR (sonic-net/sonic-buildimage#7676) was tested on virtual testbed. monit/test_monit_status.py::test_monit_status[vlab-03] PASSED [ 50%] monit/test_monit_status.py::test_monit_reporting_message[vlab-03] -------------------------------- live log call --------------------------------- 02:11:26 utilities.wait_until L0068 ERROR | Exception caught while checking check_monit_last_output: IndexError('list index out of range',) 02:12:26 utilities.wait_until L0068 ERROR | Exception caught while checking check_monit_last_output: IndexError('list index out of range',) 02:13:27 utilities.wait_until L0068 ERROR | Exception caught while checking check_monit_last_output: IndexError('list index out of range',) FAILED How did you do it? I used the pytest_require(...) to skip the testbed which were installed 202012 or newer image version. How did you verify/test it? I verified this change on the testbed str-msn2700-03. Any platform specific information? N/A Supported testbed topology if it's a new test case? N/A
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jleveque
approved these changes
Jun 4, 2021
|
This could not be cleanly cherry-picked to 202012. Please submit another PR. |
I will submit a separate PR for 202012 branch. |
judyjoseph
added a commit
to judyjoseph/sonic-buildimage
that referenced
this pull request
Jun 29, 2021
4 tasks
judyjoseph
added a commit
that referenced
this pull request
Jun 29, 2021
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
… Monit (sonic-net#7676) Signed-off-by: Yong Zhao yozhao@microsoft.com Why I did it Currently we leveraged the Supervisor to monitor the running status of critical processes in each container and it is more reliable and flexible than doing the monitoring by Monit. So we removed the functionality of monitoring the critical processes by Monit. How I did it I removed the script process_checker and corresponding Monit configuration entries of critical processes. How to verify it I verified this on the device str-7260cx3-acs-1.
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
Remove the references to file monit_syncd from docker-syncd-brcm-dnx, which got missed as the PR sonic-net#7598 overlapped sonic-net#7676
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
…2012 image (sonic-net#3559) What is the motivation for this PR? Since Supervisord will replace Monit to do the monitoring of critical processes, this test needs skip the testbeds which were installed with 202012 or newer image version. At the same time, this test needs handle the error if the command sudo monit status 'lldp|lldpmgrd' returns the non-zero exit code. I met the following error message when this PR (sonic-net/sonic-buildimage#7676) was tested on virtual testbed. monit/test_monit_status.py::test_monit_status[vlab-03] PASSED [ 50%] monit/test_monit_status.py::test_monit_reporting_message[vlab-03] -------------------------------- live log call --------------------------------- 02:11:26 utilities.wait_until L0068 ERROR | Exception caught while checking check_monit_last_output: IndexError('list index out of range',) 02:12:26 utilities.wait_until L0068 ERROR | Exception caught while checking check_monit_last_output: IndexError('list index out of range',) 02:13:27 utilities.wait_until L0068 ERROR | Exception caught while checking check_monit_last_output: IndexError('list index out of range',) FAILED How did you do it? I used the pytest_require(...) to skip the testbed which were installed 202012 or newer image version. How did you verify/test it? I verified this change on the testbed str-msn2700-03. Any platform specific information? N/A Supported testbed topology if it's a new test case? N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yong Zhao yozhao@microsoft.com
Why I did it
Currently we leveraged the Supervisor to monitor the running status of critical processes in each container and it is more reliable and flexible than doing the monitoring by Monit. So we removed the functionality of monitoring the critical processes by Monit.
How I did it
I removed the script
process_checkerand corresponding Monit configuration entries of critical processes.How to verify it
I verified this on the device
str-7260cx3-acs-1.Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)