Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate those pesky warnings #2421

Merged
merged 18 commits into from
Oct 3, 2024

Conversation

nbollis
Copy link
Contributor

@nbollis nbollis commented Oct 3, 2024

Dealt with all of the warnings we get every pull request.

Added a bunch of words to the MetaMorpheus shared dictionary to get fewer warning messages

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.67%. Comparing base (6dd10e0) to head (cca22e6).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
MetaMorpheus/EngineLayer/PsmTsv/PsmTsvReader.cs 0.00% 1 Missing ⚠️
...ViewModels/SpectralAveragingParametersViewModel.cs 96.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2421      +/-   ##
==========================================
- Coverage   93.67%   93.67%   -0.01%     
==========================================
  Files         141      141              
  Lines       21928    21925       -3     
  Branches     3007     3007              
==========================================
- Hits        20542    20539       -3     
  Misses        934      934              
  Partials      452      452              
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...entResearching/FragmentationReanalysisViewModel.cs 96.11% <100.00%> (ø)
...Morpheus/GuiFunctions/MetaDraw/MetaDrawSettings.cs 98.52% <100.00%> (ø)
...s/TaskLayer/AveragingTask/SpectralAveragingTask.cs 93.68% <100.00%> (-0.07%) ⬇️
...yer/GlycoSearchTask/PostGlycoSearchAnalysisTask.cs 91.82% <ø> (-0.02%) ⬇️
MetaMorpheus/EngineLayer/PsmTsv/PsmTsvReader.cs 89.10% <0.00%> (-0.11%) ⬇️
...ViewModels/SpectralAveragingParametersViewModel.cs 97.24% <96.00%> (ø)

@nbollis nbollis marked this pull request as ready for review October 3, 2024 14:56
@trishorts trishorts merged commit 8c8fe5f into smith-chem-wisc:master Oct 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants