Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle zkSync "known transaction" error (SHIP-1233) #12338

Merged
merged 10 commits into from
Mar 26, 2024

Conversation

friedemannf
Copy link
Member

@friedemannf friedemannf commented Mar 7, 2024

Handling the following error that is being returned by zkSync:

ErrorObject { code: ServerError(3), message: \"known transaction. transaction with hash 0xf016…ad63 is already in the system\", data: Some(RawValue(\"0x\")) }

Copy link
Contributor

github-actions bot commented Mar 7, 2024

I see that you haven't updated any README files. Would it make sense to do so?

@friedemannf friedemannf marked this pull request as ready for review March 25, 2024 23:25
@friedemannf friedemannf requested a review from a team as a code owner March 25, 2024 23:25
Copy link
Contributor

@prashantkumar1982 prashantkumar1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

Copy link
Contributor

@poopoothegorilla poopoothegorilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job

@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Mar 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 26, 2024
@cl-sonarqube-production
Copy link

@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Mar 26, 2024
Merged via the queue into develop with commit 1853cca Mar 26, 2024
103 checks passed
@prashantkumar1982 prashantkumar1982 deleted the zksync-tx-known-error branch March 26, 2024 19:16
poopoothegorilla added a commit that referenced this pull request Mar 26, 2024
* Handle zkSync "known transaction" error (SHIP-1233)

* add test case for zkSync specific known transaction error

---------

Co-authored-by: Jim W <poopoothegorilla@users.noreply.github.com>
Co-authored-by: Prashant Yadav <34992934+prashantkumar1982@users.noreply.github.com>
snehaagni added a commit that referenced this pull request Mar 27, 2024
…c-error-fix

Handle zkSync "known transaction" error (SHIP-1233) (#12338)
github-merge-queue bot pushed a commit that referenced this pull request Apr 8, 2024
* Add MetricsRegistry to automation  (#12359)

* Pin to metrics registry automation PR

* Add missing go.sum

* Pin to latest automation version

* BCF-3052 - Job Based KV Store and juelsFeePerCoin reboot persistence (#12392)

* Add kv store migration

* Add kv store implementation

* Init kv store in ocr2 delegate and pass into median service

* Update ds cache to have kv store fallback for final observation value

* Prettify ds cache updateCache, add ERR log severity on consecutive errs

* Add ds cache test for cache value persistence

* Remove unused field in jobKVStore

* Make sonar SQL migration lint happy

* Rename TestJobKVStore

* Add kv store mock

* Add changeset file

* Fix sonar sql lint

* Change kv orm to use raw json message instead of jsonText

* minor change

* minor change

* Fix SQ SQL lint

* Add comments in KVStore

* Rename jobKVStore to kVStore and return struct from constructor

* Update core/store/migrate/migrations/0227_kv_store_table.sql

Co-authored-by: Sam <samsondav@protonmail.com>

* Update kVStore sql to match migration

* Add more kv_orm tests

---------

Co-authored-by: Sam <samsondav@protonmail.com>

* Fix in memory data source cache error logging and add err log when cache is over 24h old (#12586)

* Fix in memory data source cache error logging

* Add stale jfcp cache error log and lower other logs to warn

* Update logger warnw to warnf function

Co-authored-by: Jordan Krage <jmank88@gmail.com>

---------

Co-authored-by: Jordan Krage <jmank88@gmail.com>

* Handle zkSync "known transaction" error (SHIP-1233) (#12338)

* Handle zkSync "known transaction" error (SHIP-1233)

* add test case for zkSync specific known transaction error

---------

Co-authored-by: Jim W <poopoothegorilla@users.noreply.github.com>
Co-authored-by: Prashant Yadav <34992934+prashantkumar1982@users.noreply.github.com>

* fix: trigger operator-ui-ci with specific tag (#12601)

* fix: trigger operator-ui-ci with specific tag

* fix path

* add checkout step

* update operator-ui tag

* make operator-ui

* update operator-ui-ci tag conditional (#12607)

* update operator-ui-ci tag conditional

* use main branch as default tag

* fix: check for target branch name instead of current for operator-ui-ci (#12618)

* add rebalancer support for feeds manager ocr2 plugins (#12344)

* [Functions] Fix bug in comparing subscriptions (#12379) (#12576)

Co-authored-by: Sneha Agnihotri <180277+snehaagni@users.noreply.github.com>

* Add cascade delete to kv store table fk (#12629)

* Add cascade delete to kv store table fk

* Add changeset

(cherry picked from commit 3ec8cc9)

* Fix InMemoryDataSourceCache cleanup (#12647)

* Fix InMemoryDataSourceCache cleanup

* Add changeset

* Make linter happy

* Handle data source cache unit test cleanup

* Use services.StopChan in inMemoryDataSourceCache

* Move ctxWithTimeout into updateCache

Co-authored-by: Jordan Krage <jmank88@gmail.com>

---------

Co-authored-by: Jordan Krage <jmank88@gmail.com>

* Bump operator-ui (#12684) (#12687)

* Finalize date on changelog for 2.10.0

* fix spacing

Signed-off-by: Sneha Agnihotri <sneha.agnihotri@smartcontract.com>

* Remove old operator-ui assets

---------

Signed-off-by: Sneha Agnihotri <sneha.agnihotri@smartcontract.com>
Co-authored-by: george-dorin <120329946+george-dorin@users.noreply.github.com>
Co-authored-by: ilija42 <57732589+ilija42@users.noreply.github.com>
Co-authored-by: Sam <samsondav@protonmail.com>
Co-authored-by: Jordan Krage <jmank88@gmail.com>
Co-authored-by: Friedemann Fürst <59653747+friedemannf@users.noreply.github.com>
Co-authored-by: Jim W <poopoothegorilla@users.noreply.github.com>
Co-authored-by: Prashant Yadav <34992934+prashantkumar1982@users.noreply.github.com>
Co-authored-by: frank zhu <fr@nkzhu.com>
Co-authored-by: Margaret Ma <eutopia@gmail.com>
Co-authored-by: Bolek <1416262+bolekk@users.noreply.github.com>
Co-authored-by: chainchad <96362174+chainchad@users.noreply.github.com>
Co-authored-by: george-dorin <george.dorin@smartcontract.com>
Co-authored-by: krehermann <keith.rehermann@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants