Add cascade delete to kv store table fk (#12629)

* Add cascade delete to kv store table fk * Add changeset
smartcontractkit · Mar 28, 2024 · 3ec8cc9 · 3ec8cc9
1 parent 478f73b
commit 3ec8cc9
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 0 deletions.
diff --git a/.changeset/brave-games-drop.md b/.changeset/brave-games-drop.md
@@ -0,0 +1,5 @@
+---
+"chainlink": major
+---
+
+Fix kv_store migration fk cascade deletion
diff --git a/core/services/job/kv_orm_test.go b/core/services/job/kv_orm_test.go
@@ -82,4 +82,6 @@ func TestJobKVStore(t *testing.T) {
 	require.NoError(t, kvStore.Store(key, td2))
 	require.NoError(t, kvStore.Get(key, &retData))
 	require.Equal(t, td2, retData)
+
+	require.NoError(t, jobORM.DeleteJob(jobID))
 }
diff --git a/core/store/migrate/migrations/0229_add_kv_store_job_fk_cascade_delete.sql b/core/store/migrate/migrations/0229_add_kv_store_job_fk_cascade_delete.sql
@@ -0,0 +1,23 @@
+-- +goose Up
+
+BEGIN;
+
+ALTER TABLE job_kv_store DROP CONSTRAINT job_kv_store_job_id_fkey;
+ALTER TABLE job_kv_store
+    ADD CONSTRAINT job_kv_store_job_id_fkey
+        FOREIGN KEY (job_id)
+            REFERENCES jobs(id)
+            ON DELETE CASCADE;
+
+COMMIT;
+
+-- +goose Down
+BEGIN;
+
+ALTER TABLE job_kv_store DROP CONSTRAINT job_kv_store_job_id_fkey;
+ALTER TABLE job_kv_store
+    ADD CONSTRAINT job_kv_store_job_id_fkey
+        FOREIGN KEY (job_id)
+            REFERENCES jobs(id);
+
+COMMIT;