Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1496 Async client uses blocking call when uploading file with v2 #1498
Fix #1496 Async client uses blocking call when uploading file with v2 #1498
Changes from all commits
dd804f4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 230 in slack_sdk/web/async_base_client.py
Codecov / codecov/patch
slack_sdk/web/async_base_client.py#L230
Check warning on line 239 in slack_sdk/web/async_base_client.py
Codecov / codecov/patch
slack_sdk/web/async_base_client.py#L239
Check warning on line 3586 in slack_sdk/web/async_client.py
Codecov / codecov/patch
slack_sdk/web/async_client.py#L3586
Check warning on line 3596 in slack_sdk/web/async_client.py
Codecov / codecov/patch
slack_sdk/web/async_client.py#L3594-L3596
Check warning on line 123 in slack_sdk/web/async_internal_utils.py
Codecov / codecov/patch
slack_sdk/web/async_internal_utils.py#L122-L123
Check warning on line 580 in slack_sdk/web/base_client.py
Codecov / codecov/patch
slack_sdk/web/base_client.py#L580
Check warning on line 588 in slack_sdk/web/base_client.py
Codecov / codecov/patch
slack_sdk/web/base_client.py#L588
Check warning on line 3577 in slack_sdk/web/client.py
Codecov / codecov/patch
slack_sdk/web/client.py#L3577
Check warning on line 3587 in slack_sdk/web/client.py
Codecov / codecov/patch
slack_sdk/web/client.py#L3585-L3587
Check warning on line 7 in slack_sdk/web/file_upload_v2_result.py
Codecov / codecov/patch
slack_sdk/web/file_upload_v2_result.py#L6-L7
Check warning on line 381 in slack_sdk/web/internal_utils.py
Codecov / codecov/patch
slack_sdk/web/internal_utils.py#L380-L381
Check warning on line 540 in slack_sdk/web/legacy_base_client.py
Codecov / codecov/patch
slack_sdk/web/legacy_base_client.py#L540
Check warning on line 548 in slack_sdk/web/legacy_base_client.py
Codecov / codecov/patch
slack_sdk/web/legacy_base_client.py#L548
Check warning on line 3588 in slack_sdk/web/legacy_client.py
Codecov / codecov/patch
slack_sdk/web/legacy_client.py#L3588
Check warning on line 3598 in slack_sdk/web/legacy_client.py
Codecov / codecov/patch
slack_sdk/web/legacy_client.py#L3596-L3598