Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1496 Async client uses blocking call when uploading file with v2 #1498

Merged
merged 1 commit into from
May 16, 2024

Fix #1496 Async client uses blocking call when uploading file with v2

dd804f4
Select commit
Loading
Failed to load commit list.
Merged

Fix #1496 Async client uses blocking call when uploading file with v2 #1498

Fix #1496 Async client uses blocking call when uploading file with v2
dd804f4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed May 16, 2024 in 0s

38.46% of diff hit (target 50.00%)

View this Pull Request on Codecov

38.46% of diff hit (target 50.00%)

Annotations

Check warning on line 230 in slack_sdk/web/async_base_client.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

slack_sdk/web/async_base_client.py#L230 

Added line #L230 was not covered by tests

Check warning on line 239 in slack_sdk/web/async_base_client.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

slack_sdk/web/async_base_client.py#L239 

Added line #L239 was not covered by tests

Check warning on line 3586 in slack_sdk/web/async_client.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

slack_sdk/web/async_client.py#L3586 

Added line #L3586 was not covered by tests

Check warning on line 3596 in slack_sdk/web/async_client.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

slack_sdk/web/async_client.py#L3594-L3596 

Added lines #L3594 - L3596 were not covered by tests

Check warning on line 123 in slack_sdk/web/async_internal_utils.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

slack_sdk/web/async_internal_utils.py#L122-L123 

Added lines #L122 - L123 were not covered by tests

Check warning on line 580 in slack_sdk/web/base_client.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

slack_sdk/web/base_client.py#L580 

Added line #L580 was not covered by tests

Check warning on line 588 in slack_sdk/web/base_client.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

slack_sdk/web/base_client.py#L588 

Added line #L588 was not covered by tests

Check warning on line 3577 in slack_sdk/web/client.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

slack_sdk/web/client.py#L3577 

Added line #L3577 was not covered by tests

Check warning on line 3587 in slack_sdk/web/client.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

slack_sdk/web/client.py#L3585-L3587 

Added lines #L3585 - L3587 were not covered by tests

Check warning on line 7 in slack_sdk/web/file_upload_v2_result.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

slack_sdk/web/file_upload_v2_result.py#L6-L7 

Added lines #L6 - L7 were not covered by tests

Check warning on line 381 in slack_sdk/web/internal_utils.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

slack_sdk/web/internal_utils.py#L380-L381 

Added lines #L380 - L381 were not covered by tests

Check warning on line 540 in slack_sdk/web/legacy_base_client.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

slack_sdk/web/legacy_base_client.py#L540 

Added line #L540 was not covered by tests

Check warning on line 548 in slack_sdk/web/legacy_base_client.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

slack_sdk/web/legacy_base_client.py#L548 

Added line #L548 was not covered by tests

Check warning on line 3588 in slack_sdk/web/legacy_client.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

slack_sdk/web/legacy_client.py#L3588 

Added line #L3588 was not covered by tests

Check warning on line 3598 in slack_sdk/web/legacy_client.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

slack_sdk/web/legacy_client.py#L3596-L3598 

Added lines #L3596 - L3598 were not covered by tests
View more details on Codecov