[ENH] pandas 1.5.0 compatibility fix: use infer_freq in Lag if no freq passed or specified
#3456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
module:transformations
khrapovs
suggested changes
Sep 23, 2022
khrapovs
approved these changes
Sep 23, 2022
achieveordie
added a commit
that referenced
this pull request
May 23, 2023
<!-- Thanks for contributing a pull request! Please ensure you have taken a look at our contribution guide: https://github.com/sktime/sktime/blob/main/CONTRIBUTING.md --> #### Reference Issues/PRs <!-- Example: Fixes #1234. See also #3456. Please use keywords (e.g., Fixes) to create link to the issues or pull requests you resolved, so that they will automatically be closed when your pull request is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests --> Fixes #3294 Part of #3351 #### What does this implement/fix? Explain your changes. <!-- A clear and concise description of what you have implemented. --> Add `MACNNNetwork` and `MACNNClassifier`. #### Does your contribution introduce a new dependency? If yes, which one? <!-- If your contribution does add a new hard dependency, we may suggest to initially develop your contribution in a separate companion package in https://github.com/sktime/ to keep external dependencies of the core sktime package to a minimum. --> None #### What should a reviewer concentrate their feedback on? <!-- This section is particularly useful if you have a pull request that is still in development. You can guide the reviews to focus on the parts that are ready for their comments. We suggest using bullets (indicated by * or -) and filled checkboxes [x] here --> #### Did you add any tests for the change? <!-- This section is useful if you have added a test in addition to the existing ones. This will ensure that further changes to these files won't introduce the same kind of bug. It is considered good practice to add tests with newly added code to enforce the fact that the code actually works. This will reduce the chance of introducing logical bugs. --> #### Any other comments? <!-- Please be aware that we are a loose team of volunteers so patience is necessary; assistance handling other issues is very welcome. We value all user contributions, no matter how minor they are. If we are slow to review, either the pull request needs some benchmarking, tinkering, convincing, etc. or more likely the reviewers are simply busy. In either case, we ask for your understanding during the review process. --> #### PR checklist <!-- Please go through the checklist below. Please feel free to remove points if they are not applicable. --> ##### For all contributions - [ ] I've added myself to the [list of contributors](https://github.com/sktime/sktime/blob/main/CONTRIBUTORS.md) with any new badges I've earned :-) How to: add yourself to the [all-contributors file](https://github.com/sktime/sktime/blob/main/.all-contributorsrc) in the `sktime` root directory (not the `CONTRIBUTORS.md`). Common badges: `code` - fixing a bug, or adding code logic. `doc` - writing or improving documentation or docstrings. `bug` - reporting or diagnosing a bug (get this plus `code` if you also fixed the bug in the PR).`maintenance` - CI, test framework, release. See here for [full badge reference](https://allcontributors.org/docs/en/emoji-key) - [ ] Optionally, I've added myself and possibly others to the [CODEOWNERS](https://github.com/sktime/sktime/blob/main/CODEOWNERS) file - do this if you want to become the owner or maintainer of an estimator you added. See here for further details on the [algorithm maintainer role](https://www.sktime.net/en/latest/get_involved/governance.html#algorithm-maintainers). - [x] The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings. ##### For new estimators - [x] I've added the estimator to the API reference - in `docs/source/api_reference/taskname.rst`, follow the pattern. - [x] I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant `Examples` section. - [x] If the estimator relies on a soft dependency, I've set the `python_dependencies` tag and ensured dependency isolation, see the [estimator dependencies guide](https://www.sktime.net/en/latest/developer_guide/dependencies.html#adding-a-soft-dependency). <!-- Thanks for contributing! -->
fkiraly
pushed a commit
that referenced
this pull request
Jan 2, 2024
<!-- Welcome to sktime, and thanks for contributing! Please have a look at our contribution guide: https://www.sktime.net/en/latest/get_involved/contributing.html --> #### Reference Issues/PRs <!-- Example: Fixes #1234. See also #3456. Please use keywords (e.g., Fixes) to create link to the issues or pull requests you resolved, so that they will automatically be closed when your pull request is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests. If no issue exists, you can open one here: https://github.com/sktime/sktime/issues --> Fixes #5684. #### What does this implement/fix? Explain your changes. <!-- A clear and concise description of what you have implemented. --> Allows tslearn versions between (but **not** including) 0.6.0 and 0.7.0 to satisfy dependency.
yarnabrina
pushed a commit
that referenced
this pull request
Feb 4, 2024
<!-- Welcome to sktime, and thanks for contributing! Please have a look at our contribution guide: https://www.sktime.net/en/latest/get_involved/contributing.html --> #### Reference Issues/PRs <!-- Example: Fixes #1234. See also #3456. Please use keywords (e.g., Fixes) to create link to the issues or pull requests you resolved, so that they will automatically be closed when your pull request is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests. If no issue exists, you can open one here: https://github.com/sktime/sktime/issues --> Fixes #5859 #### What does this implement/fix? Explain your changes. <!-- A clear and concise description of what you have implemented. --> `mlflow` tests were missing the skip markers despite using estimators like `AutoARIMA` and `CNNClassifier` that have soft dependencies. I've added `pytest.mark.skipif` decorators on top of each fixture/test that make use of either of these estimators. #### Does your contribution introduce a new dependency? If yes, which one? <!-- Only relevant if you changed pyproject.toml. We try to minimize dependencies in the core dependency set. There are also further specific instructions to follow for soft dependencies. See here for handling dependencies in sktime: https://www.sktime.net/en/latest/developer_guide/dependencies.html --> None #### What should a reviewer concentrate their feedback on? <!-- This section is particularly useful if you have a pull request that is still in development. You can guide the reviews to focus on the parts that are ready for their comments. We suggest using bullets (indicated by * or -) and filled checkboxes [x] here --> I'm not particularly fond of cases where I find myself copy-pasting any amount of code. I can appreciate the modularity such unit tests provide but I was wondering if we could instead use classes (one for mlflow-only test, mlflow-arima tests and mlflow-tensorflow tests). #### Did you add any tests for the change? <!-- This section is useful if you have added a test in addition to the existing ones. This will ensure that further changes to these files won't introduce the same kind of bug. It is considered good practice to add tests with newly added code to enforce the fact that the code actually works. This will reduce the chance of introducing logical bugs. --> #### Any other comments? <!-- We value all user contributions, no matter how small or complex they are. If you have any questions, feel free to post in the dev-chat channel on the sktime discord https://discord.com/invite/54ACzaFsn7. If we are slow to review (>3 working days), likewise feel free to ping us on discord. Thank you for your understanding during the review process. --> #### PR checklist <!-- Please go through the checklist below. Please feel free to remove points if they are not applicable. --> ##### For all contributions - [ ] I've added myself to the [list of contributors](https://github.com/sktime/sktime/blob/main/CONTRIBUTORS.md) with any new badges I've earned :-) How to: add yourself to the [all-contributors file](https://github.com/sktime/sktime/blob/main/.all-contributorsrc) in the `sktime` root directory (not the `CONTRIBUTORS.md`). Common badges: `code` - fixing a bug, or adding code logic. `doc` - writing or improving documentation or docstrings. `bug` - reporting or diagnosing a bug (get this plus `code` if you also fixed the bug in the PR).`maintenance` - CI, test framework, release. See here for [full badge reference](https://allcontributors.org/docs/en/emoji-key) - [ ] Optionally, I've added myself and possibly others to the [CODEOWNERS](https://github.com/sktime/sktime/blob/main/CODEOWNERS) file - do this if you want to become the owner or maintainer of an estimator you added. See here for further details on the [algorithm maintainer role](https://www.sktime.net/en/latest/get_involved/governance.html#algorithm-maintainers). - [X] The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings. ##### For new estimators - [ ] I've added the estimator to the API reference - in `docs/source/api_reference/taskname.rst`, follow the pattern. - [ ] I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant `Examples` section. - [ ] If the estimator relies on a soft dependency, I've set the `python_dependencies` tag and ensured dependency isolation, see the [estimator dependencies guide](https://www.sktime.net/en/latest/developer_guide/dependencies.html#adding-a-soft-dependency). <!-- Thanks for contributing! -->
yarnabrina
pushed a commit
that referenced
this pull request
Feb 10, 2024
Addresses: #5835 <!-- Welcome to sktime, and thanks for contributing! Please have a look at our contribution guide: https://www.sktime.net/en/latest/get_involved/contributing.html --> #### Reference Issues/PRs <!-- Example: Fixes #1234. See also #3456. Please use keywords (e.g., Fixes) to create link to the issues or pull requests you resolved, so that they will automatically be closed when your pull request is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests. If no issue exists, you can open one here: https://github.com/sktime/sktime/issues --> #### What does this implement/fix? Explain your changes. <!-- A clear and concise description of what you have implemented. --> Gives `FallbackForecaster` the option of using `forecaster.predict_interval()` when all forecasters have this capability. Raises and exception if at least one forecaster does not have `predict_interval` enabled. #### Does your contribution introduce a new dependency? If yes, which one? No <!-- Only relevant if you changed pyproject.toml. We try to minimize dependencies in the core dependency set. There are also further specific instructions to follow for soft dependencies. See here for handling dependencies in sktime: https://www.sktime.net/en/latest/developer_guide/dependencies.html --> #### What should a reviewer concentrate their feedback on? <!-- This section is particularly useful if you have a pull request that is still in development. You can guide the reviews to focus on the parts that are ready for their comments. We suggest using bullets (indicated by * or -) and filled checkboxes [x] here --> #### Did you add any tests for the change? Yes <!-- This section is useful if you have added a test in addition to the existing ones. This will ensure that further changes to these files won't introduce the same kind of bug. It is considered good practice to add tests with newly added code to enforce the fact that the code actually works. This will reduce the chance of introducing logical bugs. --> #### Any other comments? <!-- We value all user contributions, no matter how small or complex they are. If you have any questions, feel free to post in the dev-chat channel on the sktime discord https://discord.com/invite/54ACzaFsn7. If we are slow to review (>3 working days), likewise feel free to ping us on discord. Thank you for your understanding during the review process. --> #### PR checklist <!-- Please go through the checklist below. Please feel free to remove points if they are not applicable. --> ##### For all contributions - [ ] I've added myself to the [list of contributors](https://github.com/sktime/sktime/blob/main/CONTRIBUTORS.md) with any new badges I've earned :-) How to: add yourself to the [all-contributors file](https://github.com/sktime/sktime/blob/main/.all-contributorsrc) in the `sktime` root directory (not the `CONTRIBUTORS.md`). Common badges: `code` - fixing a bug, or adding code logic. `doc` - writing or improving documentation or docstrings. `bug` - reporting or diagnosing a bug (get this plus `code` if you also fixed the bug in the PR).`maintenance` - CI, test framework, release. See here for [full badge reference](https://allcontributors.org/docs/en/emoji-key) - [ ] Optionally, I've added myself and possibly others to the [CODEOWNERS](https://github.com/sktime/sktime/blob/main/CODEOWNERS) file - do this if you want to become the owner or maintainer of an estimator you added. See here for further details on the [algorithm maintainer role](https://www.sktime.net/en/latest/get_involved/governance.html#algorithm-maintainers). - [ ] The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings. ##### For new estimators - [ ] I've added the estimator to the API reference - in `docs/source/api_reference/taskname.rst`, follow the pattern. - [ ] I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant `Examples` section. - [ ] If the estimator relies on a soft dependency, I've set the `python_dependencies` tag and ensured dependency isolation, see the [estimator dependencies guide](https://www.sktime.net/en/latest/developer_guide/dependencies.html#adding-a-soft-dependency). <!-- Thanks for contributing! -->
6 tasks
yarnabrina
pushed a commit
that referenced
this pull request
Mar 1, 2024
<!-- Welcome to sktime, and thanks for contributing! Please have a look at our contribution guide: https://www.sktime.net/en/latest/get_involved/contributing.html --> #### Reference Issues/PRs <!-- Example: Fixes #1234. See also #3456. Please use keywords (e.g., Fixes) to create link to the issues or pull requests you resolved, so that they will automatically be closed when your pull request is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests. If no issue exists, you can open one here: https://github.com/sktime/sktime/issues --> This fixes #5789 . #### What does this implement/fix? Explain your changes. <!-- A clear and concise description of what you have implemented. --> `SARIMAX` no longer gives an error when `X` is passed to `predict` but not to `fit`. The `X` passed to `predict` is ignored in this case i.e. it is changed to `None`. #### Does your contribution introduce a new dependency? If yes, which one? No. <!-- Only relevant if you changed pyproject.toml. We try to minimize dependencies in the core dependency set. There are also further specific instructions to follow for soft dependencies. See here for handling dependencies in sktime: https://www.sktime.net/en/latest/developer_guide/dependencies.html --> #### What should a reviewer concentrate their feedback on? <!-- This section is particularly useful if you have a pull request that is still in development. You can guide the reviews to focus on the parts that are ready for their comments. We suggest using bullets (indicated by * or -) and filled checkboxes [x] here --> #### Did you add any tests for the change? No. <!-- This section is useful if you have added a test in addition to the existing ones. This will ensure that further changes to these files won't introduce the same kind of bug. It is considered good practice to add tests with newly added code to enforce the fact that the code actually works. This will reduce the chance of introducing logical bugs. --> #### Any other comments? All check estimator tests have passed when I checked it locally. Do I have to add any additional tests? If yes, how do I go about it? <!-- We value all user contributions, no matter how small or complex they are. If you have any questions, feel free to post in the dev-chat channel on the sktime discord https://discord.com/invite/54ACzaFsn7. If we are slow to review (>3 working days), likewise feel free to ping us on discord. Thank you for your understanding during the review process. --> #### PR checklist <!-- Please go through the checklist below. Please feel free to remove points if they are not applicable. --> ##### For all contributions - [x] The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings. <!-- Thanks for contributing! -->
fkiraly
pushed a commit
that referenced
this pull request
Mar 15, 2024
…roximityTree`, and `ProximityStump` (#6046) <!-- Welcome to sktime, and thanks for contributing! Please have a look at our contribution guide: https://www.sktime.net/en/latest/get_involved/contributing.html --> #### Reference Issues/PRs <!-- Example: Fixes #1234. See also #3456. Please use keywords (e.g., Fixes) to create link to the issues or pull requests you resolved, so that they will automatically be closed when your pull request is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests. If no issue exists, you can open one here: https://github.com/sktime/sktime/issues --> Fixes #5042 #### What does this implement/fix? Explain your changes. <!-- A clear and concise description of what you have implemented. --> Removed methods that were being instantiated with the objects of `ProximityForest`, `ProximityTree`, and `ProximityStump` classes and made them the class methods. For the `get_gain` method which defaults to `gini_gain` I added a dictionary to track the gain functions in case there is more gain functions added in the future. Methods changed - [x] `setup_distance_measure` - [x] `get_exemplars` - [x] `get_distance_measure` - [x] `find_stump` - [x] `get_gain`
fkiraly
pushed a commit
that referenced
this pull request
Mar 19, 2024
<!-- Welcome to sktime, and thanks for contributing! Please have a look at our contribution guide: https://www.sktime.net/en/latest/get_involved/contributing.html --> #### Reference Issues/PRs <!-- Example: Fixes #1234. See also #3456. Please use keywords (e.g., Fixes) to create link to the issues or pull requests you resolved, so that they will automatically be closed when your pull request is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests. If no issue exists, you can open one here: https://github.com/sktime/sktime/issues --> Closes #5305. #### What does this implement/fix? Explain your changes. <!-- A clear and concise description of what you have implemented. --> This PR documents the `int_label` option in the `BaseSeriesAnnotator` class. This option is used in the the greedy gaussian segmentation model and the hidden markov model.
fkiraly
pushed a commit
that referenced
this pull request
Mar 20, 2024
Enhances `NeuralForecastRNN` to interpret `freq` from `ForecastingHorizon` when passed as `"auto"` <!-- Welcome to sktime, and thanks for contributing! Please have a look at our contribution guide: https://www.sktime.net/en/latest/get_involved/contributing.html --> #### Reference Issues/PRs <!-- Example: Fixes #1234. See also #3456. Please use keywords (e.g., Fixes) to create link to the issues or pull requests you resolved, so that they will automatically be closed when your pull request is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests. If no issue exists, you can open one here: https://github.com/sktime/sktime/issues --> Fixes #6003. #### What does this implement/fix? Explain your changes. <!-- A clear and concise description of what you have implemented. --> The `NeuralForecastRNN` constructor previously required a `freq` argument, which is now proposed to default to `"auto"` in which case it interprets `freq` from `ForecastingHorizon`, leveraging `fh.freq` in the `fit` method. #### What should a reviewer concentrate their feedback on? <!-- This section is particularly useful if you have a pull request that is still in development. You can guide the reviews to focus on the parts that are ready for their comments. We suggest using bullets (indicated by * or -) and filled checkboxes [x] here --> I have run the tests with the updated estimator ```py results = check_estimator(NeuralForecastRNN) # All tests PASSED! ``` `freq` can now be passed like this: ```py y, X = load_longley() y_train, y_test, X_train, X_test = temporal_train_test_split(y, X, test_size=4) model = NeuralForecastRNN( "auto", # interprets to be "A-DEC" futr_exog_list=["ARMED", "POP"], max_steps=5) model.fit(y_train, X=X_train, fh=[1, 2, 3, 4]) model.predict(X=X_test) # Seed set to 1 # 1959 66241.984375 # 1960 66700.132812 # 1961 66550.195312 # 1962 67310.007812 # Freq: A-DEC, Name: TOTEMP, dtype: float64 ```
fkiraly
pushed a commit
that referenced
this pull request
Mar 25, 2024
…ility (#6141) Improved numerical stability by setting a tolerance threshold for standard deviation calculation in shapelet transform. This change from use_std = std != 0 to use_std = std > 1e-8 prevents potential NaN values by avoiding division by extremely small numbers, addressing issues related to the precision limits of floating-point arithmetic. #### Reference Issues/PRs <!-- Example: Fixes #1234. See also #3456. Please use keywords (e.g., Fixes) to create link to the issues or pull requests you resolved, so that they will automatically be closed when your pull request is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests. If no issue exists, you can open one here: https://github.com/sktime/sktime/issues --> This PR addresses the NaN issue discussed in [#4073](#4073). By introducing a tolerance threshold for the standard deviation calculation, it aims to resolve the NaN values encountered in certain cases. #### What does this implement/fix? Explain your changes. Enhances the `_online_shapelet_distance` function's robustness by introducing a tolerance threshold (`1e-8`) for the standard deviation (`std`) calculation, ensuring numerical stability and preventing NaN values in shapelet transform calculations. #### Does your contribution introduce a new dependency? If yes, which one? No new dependencies introduced. #### What should a reviewer concentrate their feedback on? - The choice of the `1e-8` threshold for numerical stability. - Potential impacts on the accuracy and performance of the shapelet transform function.
yarnabrina
pushed a commit
that referenced
this pull request
Apr 19, 2024
<!-- Welcome to sktime, and thanks for contributing! Please have a look at our contribution guide: https://www.sktime.net/en/latest/get_involved/contributing.html --> #### Reference Issues/PRs <!-- Example: Fixes #1234. See also #3456. Please use keywords (e.g., Fixes) to create link to the issues or pull requests you resolved, so that they will automatically be closed when your pull request is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests. If no issue exists, you can open one here: https://github.com/sktime/sktime/issues --> #### What does this implement/fix? Explain your changes. <!-- A clear and concise description of what you have implemented. --> "In this implementation, within the _window_feature function, if the summarizer is a callable function, it will perform a rolling operation and apply the custom function. However, in the backfill stage, which the previous author set up to use 'Z' for backfilling, the custom function is not applied. #### Does your contribution introduce a new dependency? If yes, which one? No <!-- Only relevant if you changed pyproject.toml. We try to minimize dependencies in the core dependency set. There are also further specific instructions to follow for soft dependencies. See here for handling dependencies in sktime: https://www.sktime.net/en/latest/developer_guide/dependencies.html --> #### What should a reviewer concentrate their feedback on? <!-- This section is particularly useful if you have a pull request that is still in development. You can guide the reviews to focus on the parts that are ready for their comments. We suggest using bullets (indicated by * or -) and filled checkboxes [x] here --> #### Did you add any tests for the change? <!-- This section is useful if you have added a test in addition to the existing ones. This will ensure that further changes to these files won't introduce the same kind of bug. It is considered good practice to add tests with newly added code to enforce the fact that the code actually works. This will reduce the chance of introducing logical bugs. --> #### Any other comments? <!-- We value all user contributions, no matter how small or complex they are. If you have any questions, feel free to post in the dev-chat channel on the sktime discord https://discord.com/invite/54ACzaFsn7. If we are slow to review (>3 working days), likewise feel free to ping us on discord. Thank you for your understanding during the review process. --> #### PR checklist <!-- Please go through the checklist below. Please feel free to remove points if they are not applicable. --> ##### For all contributions - [ ] I've added myself to the [list of contributors](https://github.com/sktime/sktime/blob/main/CONTRIBUTORS.md) with any new badges I've earned :-) How to: add yourself to the [all-contributors file](https://github.com/sktime/sktime/blob/main/.all-contributorsrc) in the `sktime` root directory (not the `CONTRIBUTORS.md`). Common badges: `code` - fixing a bug, or adding code logic. `doc` - writing or improving documentation or docstrings. `bug` - reporting or diagnosing a bug (get this plus `code` if you also fixed the bug in the PR).`maintenance` - CI, test framework, release. See here for [full badge reference](https://allcontributors.org/docs/en/emoji-key) - [ ] Optionally, for added estimators: I've added myself and possibly to the `maintainers` tag - do this if you want to become the owner or maintainer of an estimator you added. See here for further details on the [algorithm maintainer role](https://www.sktime.net/en/latest/get_involved/governance.html#algorithm-maintainers). - [ ] The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings. ##### For new estimators - [ ] I've added the estimator to the API reference - in `docs/source/api_reference/taskname.rst`, follow the pattern. - [ ] I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant `Examples` section. - [ ] If the estimator relies on a soft dependency, I've set the `python_dependencies` tag and ensured dependency isolation, see the [estimator dependencies guide](https://www.sktime.net/en/latest/developer_guide/dependencies.html#adding-a-soft-dependency). <!-- Thanks for contributing! -->
yarnabrina
pushed a commit
that referenced
this pull request
May 23, 2024
) <!-- Welcome to sktime, and thanks for contributing! Please have a look at our contribution guide: https://www.sktime.net/en/latest/get_involved/contributing.html --> #### Reference Issues/PRs <!-- Example: Fixes #1234. See also #3456. Please use keywords (e.g., Fixes) to create link to the issues or pull requests you resolved, so that they will automatically be closed when your pull request is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests. If no issue exists, you can open one here: https://github.com/sktime/sktime/issues --> fixes #6405 #### What does this implement/fix? Explain your changes. <!-- A clear and concise description of what you have implemented. --> The issue was the way we were handling the complementation of the columns. #### PR checklist ##### For all contributions - [x] The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings. <!-- Thanks for contributing! -->
fkiraly
pushed a commit
that referenced
this pull request
Jun 1, 2024
…llback` parameter (#6239) <!-- Welcome to sktime, and thanks for contributing! Please have a look at our contribution guide: https://www.sktime.net/en/latest/get_involved/contributing.html --> #### Reference Issues/PRs <!-- Example: Fixes #1234. See also #3456. Please use keywords (e.g., Fixes) to create link to the issues or pull requests you resolved, so that they will automatically be closed when your pull request is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests. If no issue exists, you can open one here: https://github.com/sktime/sktime/issues --> Fixes check_estimator for #6153 and partially solves it. #### What does this implement/fix? Explain your changes. <!-- A clear and concise description of what you have implemented. --> It corrects the `test_fit_does_not_overwrite_hyper_params` by replacing the `callback = []` to `callback = None` as originally referenced.
fkiraly
pushed a commit
that referenced
this pull request
Jun 3, 2024
<!-- Welcome to sktime, and thanks for contributing! Please have a look at our contribution guide: https://www.sktime.net/en/latest/get_involved/contributing.html --> #### Reference Issues/PRs <!-- Example: Fixes #1234. See also #3456. Please use keywords (e.g., Fixes) to create link to the issues or pull requests you resolved, so that they will automatically be closed when your pull request is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests. If no issue exists, you can open one here: https://github.com/sktime/sktime/issues --> Fixes #6507 #### What does this implement/fix? Explain your changes. <!-- A clear and concise description of what you have implemented. --> - Fixes an error caused by dictionary unpacking on a list - Removes numpy restriction on ForecastingSkoptSearchCV which was causing tests to be skipped #### Does your contribution introduce a new dependency? If yes, which one? <!-- Only relevant if you changed pyproject.toml. We try to minimize dependencies in the core dependency set. There are also further specific instructions to follow for soft dependencies. See here for handling dependencies in sktime: https://www.sktime.net/en/latest/developer_guide/dependencies.html --> No #### What should a reviewer concentrate their feedback on? <!-- This section is particularly useful if you have a pull request that is still in development. You can guide the reviews to focus on the parts that are ready for their comments. We suggest using bullets (indicated by * or -) and filled checkboxes [x] here --> #### Did you add any tests for the change? <!-- This section is useful if you have added a test in addition to the existing ones. This will ensure that further changes to these files won't introduce the same kind of bug. It is considered good practice to add tests with newly added code to enforce the fact that the code actually works. This will reduce the chance of introducing logical bugs. --> No, as bug already captured by existing tests (they were just skipped) #### Any other comments? <!-- We value all user contributions, no matter how small or complex they are. If you have any questions, feel free to post in the dev-chat channel on the sktime discord https://discord.com/invite/54ACzaFsn7. If we are slow to review (>3 working days), likewise feel free to ping us on discord. Thank you for your understanding during the review process. --> #### PR checklist <!-- Please go through the checklist below. Please feel free to remove points if they are not applicable. --> ##### For all contributions - [x] I've added myself to the [list of contributors](https://github.com/sktime/sktime/blob/main/CONTRIBUTORS.md) with any new badges I've earned :-) How to: add yourself to the [all-contributors file](https://github.com/sktime/sktime/blob/main/.all-contributorsrc) in the `sktime` root directory (not the `CONTRIBUTORS.md`). Common badges: `code` - fixing a bug, or adding code logic. `doc` - writing or improving documentation or docstrings. `bug` - reporting or diagnosing a bug (get this plus `code` if you also fixed the bug in the PR).`maintenance` - CI, test framework, release. See here for [full badge reference](https://allcontributors.org/docs/en/emoji-key) - [x] The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings. <!-- Thanks for contributing! -->
geetu040
pushed a commit
to geetu040/sktime
that referenced
this pull request
Jun 4, 2024
…time#6433) <!-- Welcome to sktime, and thanks for contributing! Please have a look at our contribution guide: https://www.sktime.net/en/latest/get_involved/contributing.html --> #### Reference Issues/PRs <!-- Example: Fixes sktime#1234. See also sktime#3456. Please use keywords (e.g., Fixes) to create link to the issues or pull requests you resolved, so that they will automatically be closed when your pull request is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests. If no issue exists, you can open one here: https://github.com/sktime/sktime/issues --> fixes sktime#6405 #### What does this implement/fix? Explain your changes. <!-- A clear and concise description of what you have implemented. --> The issue was the way we were handling the complementation of the columns. #### PR checklist ##### For all contributions - [x] The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings. <!-- Thanks for contributing! -->
geetu040
pushed a commit
to geetu040/sktime
that referenced
this pull request
Jun 4, 2024
…llback` parameter (sktime#6239) <!-- Welcome to sktime, and thanks for contributing! Please have a look at our contribution guide: https://www.sktime.net/en/latest/get_involved/contributing.html --> #### Reference Issues/PRs <!-- Example: Fixes sktime#1234. See also sktime#3456. Please use keywords (e.g., Fixes) to create link to the issues or pull requests you resolved, so that they will automatically be closed when your pull request is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests. If no issue exists, you can open one here: https://github.com/sktime/sktime/issues --> Fixes check_estimator for sktime#6153 and partially solves it. #### What does this implement/fix? Explain your changes. <!-- A clear and concise description of what you have implemented. --> It corrects the `test_fit_does_not_overwrite_hyper_params` by replacing the `callback = []` to `callback = None` as originally referenced.
geetu040
pushed a commit
to geetu040/sktime
that referenced
this pull request
Jun 4, 2024
<!-- Welcome to sktime, and thanks for contributing! Please have a look at our contribution guide: https://www.sktime.net/en/latest/get_involved/contributing.html --> #### Reference Issues/PRs <!-- Example: Fixes sktime#1234. See also sktime#3456. Please use keywords (e.g., Fixes) to create link to the issues or pull requests you resolved, so that they will automatically be closed when your pull request is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests. If no issue exists, you can open one here: https://github.com/sktime/sktime/issues --> Fixes sktime#6507 #### What does this implement/fix? Explain your changes. <!-- A clear and concise description of what you have implemented. --> - Fixes an error caused by dictionary unpacking on a list - Removes numpy restriction on ForecastingSkoptSearchCV which was causing tests to be skipped #### Does your contribution introduce a new dependency? If yes, which one? <!-- Only relevant if you changed pyproject.toml. We try to minimize dependencies in the core dependency set. There are also further specific instructions to follow for soft dependencies. See here for handling dependencies in sktime: https://www.sktime.net/en/latest/developer_guide/dependencies.html --> No #### What should a reviewer concentrate their feedback on? <!-- This section is particularly useful if you have a pull request that is still in development. You can guide the reviews to focus on the parts that are ready for their comments. We suggest using bullets (indicated by * or -) and filled checkboxes [x] here --> #### Did you add any tests for the change? <!-- This section is useful if you have added a test in addition to the existing ones. This will ensure that further changes to these files won't introduce the same kind of bug. It is considered good practice to add tests with newly added code to enforce the fact that the code actually works. This will reduce the chance of introducing logical bugs. --> No, as bug already captured by existing tests (they were just skipped) #### Any other comments? <!-- We value all user contributions, no matter how small or complex they are. If you have any questions, feel free to post in the dev-chat channel on the sktime discord https://discord.com/invite/54ACzaFsn7. If we are slow to review (>3 working days), likewise feel free to ping us on discord. Thank you for your understanding during the review process. --> #### PR checklist <!-- Please go through the checklist below. Please feel free to remove points if they are not applicable. --> ##### For all contributions - [x] I've added myself to the [list of contributors](https://github.com/sktime/sktime/blob/main/CONTRIBUTORS.md) with any new badges I've earned :-) How to: add yourself to the [all-contributors file](https://github.com/sktime/sktime/blob/main/.all-contributorsrc) in the `sktime` root directory (not the `CONTRIBUTORS.md`). Common badges: `code` - fixing a bug, or adding code logic. `doc` - writing or improving documentation or docstrings. `bug` - reporting or diagnosing a bug (get this plus `code` if you also fixed the bug in the PR).`maintenance` - CI, test framework, release. See here for [full badge reference](https://allcontributors.org/docs/en/emoji-key) - [x] The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings. <!-- Thanks for contributing! -->
fkiraly
pushed a commit
that referenced
this pull request
Jul 3, 2024
<!-- Welcome to sktime, and thanks for contributing! Please have a look at our contribution guide: https://www.sktime.net/en/latest/get_involved/contributing.html --> #### Reference Issues/PRs <!-- Example: Fixes #1234. See also #3456. Please use keywords (e.g., Fixes) to create link to the issues or pull requests you resolved, so that they will automatically be closed when your pull request is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests. If no issue exists, you can open one here: https://github.com/sktime/sktime/issues --> Fixes #6435. #### What does this implement/fix? Explain your changes. <!-- A clear and concise description of what you have implemented. --> This PR extends the `fit_strategy` of `HFTransformersForecaster` for these `PEFT` methods 1. LoRa 2. LoHa 3. AdaLora #### Does your contribution introduce a new dependency? If yes, which one? yes, it introduces `peft` #### Did you add any tests for the change? Yes, I have added the tests for `fit_strategy` param in `test_hf_transformers_forecaster.py`
yarnabrina
pushed a commit
that referenced
this pull request
Jul 19, 2024
<!-- Welcome to sktime, and thanks for contributing! Please have a look at our contribution guide: https://www.sktime.net/en/latest/get_involved/contributing.html --> #### Reference Issues/PRs <!-- Example: Fixes #1234. See also #3456. Please use keywords (e.g., Fixes) to create link to the issues or pull requests you resolved, so that they will automatically be closed when your pull request is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests. If no issue exists, you can open one here: https://github.com/sktime/sktime/issues --> Reference umbrella issue : #6109 #### What does this implement/fix? Explain your changes. <!-- A clear and concise description of what you have implemented. --> Added a tag to identify capability of estimator to natively support categorical in X. #### Does your contribution introduce a new dependency? If yes, which one? No. <!-- Only relevant if you changed pyproject.toml. We try to minimize dependencies in the core dependency set. There are also further specific instructions to follow for soft dependencies. See here for handling dependencies in sktime: https://www.sktime.net/en/latest/developer_guide/dependencies.html --> #### What should a reviewer concentrate their feedback on? <!-- This section is particularly useful if you have a pull request that is still in development. You can guide the reviews to focus on the parts that are ready for their comments. We suggest using bullets (indicated by * or -) and filled checkboxes [x] here --> #### Did you add any tests for the change? No. <!-- This section is useful if you have added a test in addition to the existing ones. This will ensure that further changes to these files won't introduce the same kind of bug. It is considered good practice to add tests with newly added code to enforce the fact that the code actually works. This will reduce the chance of introducing logical bugs. --> #### Any other comments? <!-- We value all user contributions, no matter how small or complex they are. If you have any questions, feel free to post in the dev-chat channel on the sktime discord https://discord.com/invite/54ACzaFsn7. If we are slow to review (>3 working days), likewise feel free to ping us on discord. Thank you for your understanding during the review process. --> #### PR checklist <!-- Please go through the checklist below. Please feel free to remove points if they are not applicable. --> ##### For all contributions - [x] The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings. <!-- Thanks for contributing! -->
yarnabrina
pushed a commit
that referenced
this pull request
Jul 19, 2024
<!-- Welcome to sktime, and thanks for contributing! Please have a look at our contribution guide: https://www.sktime.net/en/latest/get_involved/contributing.html --> #### Reference Issues/PRs <!-- Example: Fixes #1234. See also #3456. Please use keywords (e.g., Fixes) to create link to the issues or pull requests you resolved, so that they will automatically be closed when your pull request is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests. If no issue exists, you can open one here: https://github.com/sktime/sktime/issues --> Fixes #6470. #### What does this implement/fix? Explain your changes. <!-- A clear and concise description of what you have implemented. --> Adding a feature_kind field to metadata to store info about datatypes of columns. #### Does your contribution introduce a new dependency? If yes, which one? No. <!-- Only relevant if you changed pyproject.toml. We try to minimize dependencies in the core dependency set. There are also further specific instructions to follow for soft dependencies. See here for handling dependencies in sktime: https://www.sktime.net/en/latest/developer_guide/dependencies.html --> #### What should a reviewer concentrate their feedback on? <!-- This section is particularly useful if you have a pull request that is still in development. You can guide the reviews to focus on the parts that are ready for their comments. We suggest using bullets (indicated by * or -) and filled checkboxes [x] here --> #### Did you add any tests for the change? Yes. <!-- This section is useful if you have added a test in addition to the existing ones. This will ensure that further changes to these files won't introduce the same kind of bug. It is considered good practice to add tests with newly added code to enforce the fact that the code actually works. This will reduce the chance of introducing logical bugs. --> #### Any other comments? <!-- We value all user contributions, no matter how small or complex they are. If you have any questions, feel free to post in the dev-chat channel on the sktime discord https://discord.com/invite/54ACzaFsn7. If we are slow to review (>3 working days), likewise feel free to ping us on discord. Thank you for your understanding during the review process. --> #### PR checklist <!-- Please go through the checklist below. Please feel free to remove points if they are not applicable. --> ##### For all contributions - [x] The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings. <!-- Thanks for contributing! --> --------- Co-authored-by: Franz Király <f.kiraly@ucl.ac.uk>
yarnabrina
pushed a commit
that referenced
this pull request
Sep 20, 2024
<!-- Welcome to sktime, and thanks for contributing! Please have a look at our contribution guide: https://www.sktime.net/en/latest/get_involved/contributing.html --> #### Reference Issues/PRs <!-- Example: Fixes #1234. See also #3456. Please use keywords (e.g., Fixes) to create link to the issues or pull requests you resolved, so that they will automatically be closed when your pull request is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests. If no issue exists, you can open one here: https://github.com/sktime/sktime/issues --> Adds to #4264 #### What does this implement/fix? Explain your changes. <!-- A clear and concise description of what you have implemented. --> Adds one docstring example to TimeSeriesKernelKMeans #### Does your contribution introduce a new dependency? If yes, which one? No <!-- Only relevant if you changed pyproject.toml. We try to minimize dependencies in the core dependency set. There are also further specific instructions to follow for soft dependencies. See here for handling dependencies in sktime: https://www.sktime.net/en/latest/developer_guide/dependencies.html --> <!-- This section is particularly useful if you have a pull request that is still in development. You can guide the reviews to focus on the parts that are ready for their comments. We suggest using bullets (indicated by * or -) and filled checkboxes [x] here --> #### Did you add any tests for the change? No <!-- This section is useful if you have added a test in addition to the existing ones. This will ensure that further changes to these files won't introduce the same kind of bug. It is considered good practice to add tests with newly added code to enforce the fact that the code actually works. This will reduce the chance of introducing logical bugs. --> #### PR checklist <!-- Please go through the checklist below. Please feel free to remove points if they are not applicable. --> ##### For all contributions - [x] I've added myself to the [list of contributors](https://github.com/sktime/sktime/blob/main/CONTRIBUTORS.md) with any new badges I've earned :-) How to: add yourself to the [all-contributors file](https://github.com/sktime/sktime/blob/main/.all-contributorsrc) in the `sktime` root directory (not the `CONTRIBUTORS.md`). Common badges: `code` - fixing a bug, or adding code logic. `doc` - writing or improving documentation or docstrings. `bug` - reporting or diagnosing a bug (get this plus `code` if you also fixed the bug in the PR).`maintenance` - CI, test framework, release. See here for [full badge reference](https://allcontributors.org/docs/en/emoji-key) - [ ] Optionally, for added estimators: I've added myself and possibly to the `maintainers` tag - do this if you want to become the owner or maintainer of an estimator you added. See here for further details on the [algorithm maintainer role](https://www.sktime.net/en/latest/get_involved/governance.html#algorithm-maintainers). - [x] The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings. <!-- Thanks for contributing! -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempted fix for failure in #3450 after update to pandas 1.5.0.
This ensures that
Lagusesinfer_freqif nofreqpassed or specified.