Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Update tslearn dependency version in pyproject.toml #5686

Merged
merged 5 commits into from
Jan 2, 2024

Conversation

DManowitz
Copy link
Contributor

Reference Issues/PRs

Fixes #5684.

What does this implement/fix? Explain your changes.

Allows tslearn versions between (but not including) 0.6.0 and 0.7.0 to satisfy dependency.

Does your contribution introduce a new dependency? If yes, which one?

No new dependencies added; only updating allowable versions of optional dependency.

What should a reviewer concentrate their feedback on?

Did you add any tests for the change?

No new tests added.

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the sktime root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • Optionally, I've added myself and possibly others to the CODEOWNERS file - do this if you want to become the owner or maintainer of an estimator you added.
    See here for further details on the algorithm maintainer role.
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
For new estimators
  • I've added the estimator to the API reference - in docs/source/api_reference/taskname.rst, follow the pattern.
  • I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant Examples section.
  • If the estimator relies on a soft dependency, I've set the python_dependencies tag and ensured
    dependency isolation, see the estimator dependencies guide.

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Jan 1, 2024
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Contributor credits should go in all-contributorsrc, not in CONTRIBUTORS.md, the latter is updated from the former automatically.

(you should get the maintenance badge)

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All passed, thanks!

@fkiraly fkiraly merged commit 40c8e4f into sktime:main Jan 2, 2024
189 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Relax pin on tslearn
2 participants