-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GNOME terminal not always present when using "Open in Shell" for first time #344
Comments
@jmejia32 apologies for the delay in replying. Is this issue that "GNOME Terminal" is shown despite not having it installed? Or is the issue that Deepin Terminal doesn't work? |
@shiftkey "GNOME Terminal" is shown regardless it is installed or not, and Deepin Terminal works so far. Other applications call it as default terminal emulator. |
PD: Currently, I use Debian distro (11 - bullseye - testing branch) + Cinnamon DE because IT security requirements in office, but I have a dual boot of both systems and the issue still exists under that environment. It is not related to Deepin only. |
There's some history in here that I'm hazy on, but on initial launch we don't have a selected terminal and the placeholder we use is a best guess. This works fine on Windows and macOS because we know what shells are available by default, but clearly that won't work for Linux due to the different permutations of configurations available. It'd be nice to be able to probe on this first launch and see what shells are installed, and choose the first valid shell, but I'm not sure if we have a suitable hook to do that. |
Hi all, I am currently experiencing this issue as well on KDE Manjaro with GitHub Desktop installed from the AUR. Interestingly, when I built GitHub Desktop from source and ran it, I found that the I was able to see that when debugging In tried in my source-compiled Desktop instance but placed the breakpoint at The TL;DR of this:
I would be happy to provide more info on this to help debug this if needed. If there is a way to clear the setting to reproduce it, I would love to dig further. |
If you don't want to patch it yourself, using the dev tools and setting breakpoints following the above post while changing the terminal emulator works without having to modify anything. |
these issues are caused by gnome terminal being the default in the code, a simple way to fix this is to install a second different terminal, switch to it, then switch to the terminal you want to use, and then uninstall the second terminal. This worked well for me as shown in pr #700 |
I have the same problem. On Kubuntu, the default terminal is the Konsole, but the "Open in " UI still shows the GNOME terminal, which doesn't work; giving a path error. KDE doesn't come with a GNOME terminal. The workaround seems to be going into the setting and manually setting the integrations to Konsole. I think the default terminal detection logic should be improved. Checking more famous terminal apps by default and skipping those that are not installed. |
Thanks to @Daniel-McCarthy for the tip on working around this. A few screenshots for posterity of my fix on KDE Manjaro.
|
Addresses issue described at shiftkey#344
Addresses issue described at shiftkey#344
Describe the bug
Can't open repository folder in terminal on Deepin DE (also fails on Deepin OS distro)
Version & OS
Github Desktop Version: 2.5.4-linux1
OS: Arch Linux x64 - kernel version: 5.8.8-arch1-1
Steps to reproduce the behavior
GNOME
(?) Terminal' menu item (no GNOME installed)Expected behavior
System's default Virtual Terminal Emulator (Deepin Terminal, in my case) started on repository folder
Actual behavior
This message:
Screenshots
Compared to referenced issue #167 , Deepin Terminal finally appears in shell menu
Logs
The text was updated successfully, but these errors were encountered: