Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't open repository folder in terminal #167

Closed
jmejia32 opened this issue Jul 7, 2019 · 5 comments · Fixed by #169
Closed

Can't open repository folder in terminal #167

jmejia32 opened this issue Jul 7, 2019 · 5 comments · Fixed by #169

Comments

@jmejia32
Copy link

jmejia32 commented Jul 7, 2019

Description

Version

  • GitHub Desktop: 2.1.0-linux1
  • Operating system: Arch Linux x64

Steps to Reproduce

  1. Open a local repository
  2. Go to Repository menu
  3. Click on 'Open in GNOME(?) Terminal' menu item (I use Deepin DE btw, no GNOME installed)

Expected Behavior

System's default Virtual Terminal Emulator (Deepin Terminal, in my case) started on repository folder

Actual Behavior

This message:

image

Additional Information

  1. Package installed directly from AUR
  2. This error may be caused by this issue

image

#127 reports same problem but it's related with snap packages and obviously, it's not my case.

Logs

Log files doesn't see anything related with extrange behavior explained here.

@immackay
Copy link

The currently supports shells are Gnome, Mate, Tilix, Terminator, Urxvt, Konsole, Xterm, and Terminology.

I'll open a pull request to provide support for deepin-terminal but it may be a week or two before you see it in a release. Once the PR is merged you can alternatively install from source using github-desktop-git

@jmejia32
Copy link
Author

@immackay Great. Thanks, I really appreciate it.

@nicekiwi
Copy link

nicekiwi commented Aug 31, 2020

I've created a PR based on @immackay 's PR to support the XFCE Terminal too. #331

@jmejia32
Copy link
Author

Guys, I think we have a problem...

Deepin terminal finally appears in shell menu
image

But It can't open the project folder in terminal yet:
image

image

Version: 2.5.4-linux1

@shiftkey
Copy link
Owner

@jmejia32 please open a new issue for that specific terminal, as it might be mis-configured

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants