Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firstLetters): remove spaces from firstLetter input strings #161

Merged

Conversation

Harjot1Singh
Copy link
Member

Summary of PR

Prevents undefined being outputted in the resultant string.

Tests for unexpected behavior

  • Test suite

Time spent on PR

1hr

Linked issues

Fix #160

Reviewers

@bhajneet @sarabveer

Prevents undefined being outputted in the resultant string
Copy link
Collaborator

@sarabveer sarabveer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Harjot1Singh Harjot1Singh merged commit e2bb085 into shabados:master Jun 6, 2020
@Harjot1Singh Harjot1Singh deleted the first-letter-strip-spaces branch June 6, 2020 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

First Letter returns undefined on strings with more than 1 space
2 participants