fix(firstLetters): remove spaces from firstLetter input strings (#161)

Prevents undefined being outputted in the resultant string Fixes #160
shabados · Jun 6, 2020 · e2bb085 · e2bb085
1 parent e0799a0
commit e2bb085
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lib/firstLetters.js b/lib/firstLetters.js
@@ -32,6 +32,8 @@ const vowelFirstLetters = {
 const firstLetters = line => line
   // Split into words
   .split( ' ' )
+  // Remove any wrods that are excess spaces
+  .filter( word => word.trim().length )
   // Grab correct letter of each word
   .map( word => {
     const [ letter ] = word

diff --git a/test/firstLetters.spec.js b/test/firstLetters.spec.js
@@ -1,14 +1,16 @@
 const { expect } = require( 'chai' )
 
-const { firstLetters, toHindi, toEnglish } = require( '../index' )
+const { firstLetters, toUnicode, toHindi, toEnglish } = require( '../index' )
 
 describe( 'firstLetters(gurmukhi)', () => {
   const lines = [
+    [ 'ਗੁਰਮੁਖਿ  ਲਾਧਾ ਮਨਮੁਖਿ   ਗਵਾਇਆ ॥', 'ਗਲਮਗ॥' ],
     [ 'ਗੁਰਮੁਖਿ ਲਾਧਾ ਮਨਮੁਖਿ ਗਵਾਇਆ ॥', 'ਗਲਮਗ॥' ],
     [ 'ਜਿਨਿ ਹਰਿ ਸੇਵਿਆ ਤਿਨਿ ਸੁਖੁ ਪਾਇਆ ॥', 'ਜਹਸਤਸਪ॥' ],
     [ 'ਗ਼ੈਰਿ ਹਮਦਿ ਹੱਕ ਨਿਆਇਦ ਬਰ ਜ਼ਬਾਨਮ ਹੀਚ ਗਾਹ', 'ਗ਼ਹਹਨਬਜ਼ਹਗ' ],
     [ 'ਸਬਦਿ ਮਰੈ. ਸੋ ਮਰਿ ਰਹੈ; ਫਿਰਿ. ਮਰੈ ਨ, ਦੂਜੀ ਵਾਰ ॥', 'ਸਮ.ਸਮਰ;ਫ.ਮਨ,ਦਵ॥' ],
     [ 'ਇਕਨਾ. ਹੁਕਮੀ ਬਖਸੀਸ; ਇਕਿ, ਹੁਕਮੀ ਸਦਾ ਭਵਾਈਅਹਿ ॥', 'ੲ.ਹਬ;ੲ,ਹਸਭ॥' ],
+    [ toUnicode( 'ik hr hSqo Ssq Awmdw cwkrS [148[' ), 'ਕਹਹਸ਼ਅਚ।' ],
   ]
 
   lines.map( ( [ line, expectedFirstLetters ] ) => it( `should generate first letters for '${line}' as '${expectedFirstLetters}'`, () => {