WIP: deprecate stable and latest branches, rename to release
#1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodiscc
added
in progress
documentation
tools
ArthurHoaro
reviewed
Oct 3, 2020
application/legacy/LegacyUpdater.php
Outdated
| * Note: due to hardcoded URL and lack of dependency injection, this is not unit testable. | ||
| * | ||
| * FIXME! This needs to be removed when we switch to first digit major version | ||
| * instead of the second one since the versionning process will change. | ||
| */ | ||
| public function updateMethodCheckUpdateRemoteBranch() |
There was a problem hiding this comment.
I know this PR is a WiP, but I suggest that you let method as is - or remove it entirely - and create a new one in Shaarli\Updater\Updater: this one won't run again on instances that had already run it in the past.
- always set the target branch for update checks to `release` - update documentation (docker image tags, versioning, release procedure, README badges, migration) - doc: mention that the default-docker compose file uses the `:latest` image, update docker-compose documentation - rename the `:master` docker image tag to `:latest` - clarify method/variable names - fixes shaarli#1453
…hemes/branches/docker image tags
nodiscc
force-pushed
the
semver-release-latest
branch
from
5dcafad
to
93c1d9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release:latestimage, update docker-compose documentation:masterdocker image tag to:latest