Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker stable version to 0.11.x #1744

Closed
hydrargyrum opened this issue Apr 25, 2021 · 4 comments
Closed

Update docker stable version to 0.11.x #1744

hydrargyrum opened this issue Apr 25, 2021 · 4 comments
Labels
docker containers & cloud
Milestone

Comments

@hydrargyrum
Copy link

hydrargyrum commented Apr 25, 2021

The README states the stable version is 0.11.1.
However, the stable version on dockerhub uses shaarli 0.10.4 (that's what the footer says on every served shaarli page).

And see:

% docker run -it --entrypoint sh shaarli/shaarli:stable -c "grep v0 shaarli/README.md"
[![](https://img.shields.io/badge/stable-v0.9.7-blue.svg)](https://github.com/shaarli/Shaarli/releases/tag/v0.9.7)
[![](https://img.shields.io/badge/latest-v0.10.2-blue.svg)](https://github.com/shaarli/Shaarli/releases/tag/v0.10.2)
[![](https://img.shields.io/badge/master-v0.10.x-blue.svg)](https://github.com/shaarli/Shaarli)
@ArthurHoaro
Copy link
Member

I will update it but note that the stable branch is deprecated. #1582

@ArthurHoaro ArthurHoaro added the docker containers & cloud label May 8, 2021
@ArthurHoaro ArthurHoaro added this to the 0.12.2 milestone May 8, 2021
@hydrargyrum
Copy link
Author

When it's done, what will be new tag on docker for the stable branch? release?

@ArthurHoaro
Copy link
Member

There won't be any stable branch. It doesn't make sense regarding our release frequency (last v0.11 was release almost 2 years ago).

If you are afraid of breaking introduced bugs, you can still use deterministic version numbers.

BTW the Docker build is fixed: https://hub.docker.com/layers/shaarli/shaarli/stable/images/sha256-441d93a5c98169ce2973583712e1bee85790014452dcf252acf6bf85a9e6885a?context=repo

@hydrargyrum
Copy link
Author

If you are afraid of breaking introduced bugs, you can still use deterministic version numbers.

Pinning is always tricky as it prevents from benefiting of security fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker containers & cloud
Projects
None yet
Development

No branches or pull requests

2 participants