Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not collect unnecessary information using debug_backtrace() #5870

Closed
wants to merge 1 commit into from
Closed

Do not collect unnecessary information using debug_backtrace() #5870

wants to merge 1 commit into from

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Jun 18, 2024 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Jun 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.42%. Comparing base (bc41052) to head (913f554).

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #5870   +/-   ##
=========================================
  Coverage     92.42%   92.42%           
  Complexity     6565     6565           
=========================================
  Files           700      700           
  Lines         19786    19786           
=========================================
  Hits          18288    18288           
  Misses         1498     1498

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastianbergmann
Copy link
Owner

It should be safe for this to target 10.5.

@staabm
Copy link
Contributor Author

staabm commented Jun 18, 2024

Agree. I am afk for 2 hours

@staabm staabm changed the base branch from main to 10.5 June 18, 2024 12:21
@staabm staabm changed the base branch from 10.5 to main June 18, 2024 12:24
@staabm staabm mentioned this pull request Jun 18, 2024
Merged
@sebastianbergmann sebastianbergmann changed the title Don't calculate unnecessary information in debug_backtrace() Do not collect unnecessary information using debug_backtrace() Jun 19, 2024
@sebastianbergmann
Copy link
Owner

Cherry-picked into 11.2 and merged to main from there.

@staabm staabm deleted the less-debug branch June 19, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staabm @sebastianbergmann