Skip to content

Commit

Permalink
Don't calculate unnecessary information in debug_backtrace()
Browse files Browse the repository at this point in the history
  • Loading branch information
staabm committed Jun 18, 2024
1 parent 1e77882 commit b513684
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/Event/Value/Test/TestMethodBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public static function fromTestCase(TestCase $testCase): TestMethod
*/
public static function fromCallStack(): TestMethod
{
foreach (debug_backtrace() as $frame) {
foreach (debug_backtrace(DEBUG_BACKTRACE_PROVIDE_OBJECT | DEBUG_BACKTRACE_IGNORE_ARGS) as $frame) {

Check warning on line 52 in src/Event/Value/Test/TestMethodBuilder.php

View workflow job for this annotation

GitHub Actions / Mutation Testing

Escaped Mutant for Mutator "BitwiseOr": --- Original +++ New @@ @@ */ public static function fromCallStack(): TestMethod { - foreach (debug_backtrace(DEBUG_BACKTRACE_PROVIDE_OBJECT | DEBUG_BACKTRACE_IGNORE_ARGS) as $frame) { + foreach (debug_backtrace(DEBUG_BACKTRACE_PROVIDE_OBJECT & DEBUG_BACKTRACE_IGNORE_ARGS) as $frame) { if (isset($frame['object']) && $frame['object'] instanceof TestCase) { return $frame['object']->valueObjectForEvents(); }

Check warning on line 52 in src/Event/Value/Test/TestMethodBuilder.php

View workflow job for this annotation

GitHub Actions / Mutation Testing

Escaped Mutant for Mutator "Foreach_": --- Original +++ New @@ @@ */ public static function fromCallStack(): TestMethod { - foreach (debug_backtrace(DEBUG_BACKTRACE_PROVIDE_OBJECT | DEBUG_BACKTRACE_IGNORE_ARGS) as $frame) { + foreach ([] as $frame) { if (isset($frame['object']) && $frame['object'] instanceof TestCase) { return $frame['object']->valueObjectForEvents(); }
if (isset($frame['object']) && $frame['object'] instanceof TestCase) {
return $frame['object']->valueObjectForEvents();
}
Expand Down
2 changes: 1 addition & 1 deletion src/Framework/MockObject/MockBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,7 @@ public function disableAutoReturnValueGeneration(): self

private function calledFromTestCase(): bool
{
$caller = debug_backtrace(limit: 3)[2];
$caller = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, limit: 3)[2];

Check warning on line 555 in src/Framework/MockObject/MockBuilder.php

View workflow job for this annotation

GitHub Actions / Mutation Testing

Escaped Mutant for Mutator "IncrementInteger": --- Original +++ New @@ @@ } private function calledFromTestCase(): bool { - $caller = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, limit: 3)[2]; + $caller = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, limit: 4)[2]; return isset($caller['class']) && $caller['class'] === TestCase::class; } }

Check warning on line 555 in src/Framework/MockObject/MockBuilder.php

View workflow job for this annotation

GitHub Actions / Mutation Testing

Escaped Mutant for Mutator "DecrementInteger": --- Original +++ New @@ @@ } private function calledFromTestCase(): bool { - $caller = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, limit: 3)[2]; + $caller = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, limit: 3)[1]; return isset($caller['class']) && $caller['class'] === TestCase::class; } }

return isset($caller['class']) && $caller['class'] === TestCase::class;
}
Expand Down

0 comments on commit b513684

Please sign in to comment.