Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: bump deps and run copier with py3.10 #507

Merged
merged 18 commits into from
May 15, 2024
6 changes: 3 additions & 3 deletions .github/workflows/docs.yml
MridulS marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,12 @@ jobs:
- run: pip install --no-build-isolation --no-deps -e .
if: ${{ inputs.version == '' }}
- run: |
python -m sphinx -j2 -v -b html -d doctrees docs html
python -m sphinx -j2 -v -b doctest -d doctrees docs html
python -m sphinx -W -j2 -v -b html -d doctrees docs html
python -m sphinx -W -j2 -v -b doctest -d doctrees docs html
find html -type f -name "*.ipynb" -not -path "html/_sources/*" -delete
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the docs builds not being reported as failing because this line runs after the docs build and succeeds?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but for now I will create a new issue to track this so this PR isn't blocked. I will fix the issues in the notebooks manually.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #510 to track this.

- run: tox -e linkcheck
if: ${{ inputs.linkcheck }}
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: docs_html
path: html/
Expand Down