MAINT: bump deps and run copier with py3.10 #507
Conversation
|
@scipp/ess-maintainers Here as well. Can someone please update the protection rules? |
There was a problem hiding this comment.
The CI didn't run because of an invalid yml file:
Invalid workflow file: .github/workflows/ci.yml#L73
The workflow is not valid.
In .github/workflows/ci.yml (Line: 73, Col: 11):
Error from called workflow 26b3c1e (Line: 62, Col: 9): Unexpected value 'with'
|
Trying to run tests with the latest releases and the mantid ones are failing on scipp related ones. Need to investigate this. |
|
@nvaytet Can you check if your comment was addressed? The PR isn't merging because you requested a change. |
| - scipp>=23.07.0 | ||
| - scippnexus>=23.08.0 | ||
| - scipy>=1.7.0 | ||
| - python>=3.10 | ||
|
|
||
| {% for package in dependencies %} |
There was a problem hiding this comment.
This is now duplicating the dependencies that are listed above. We should remove the ones above, and only keep python>=3.10.
| @@ -3,16 +3,13 @@ | |||
| import doctest | |||
There was a problem hiding this comment.
Did you check that the rendered docs still look as they should?
There was a problem hiding this comment.
I did not. I can not build docs locally as mantid doesn't provide conda packages for arm based Macs.
Looking at the doc build log (which has a green check) it is failing all around inside the doc build! I will look into it :)
There was a problem hiding this comment.
I usually just download the build docs artifact from the Checks tab, unzip and view locally in a browser
There was a problem hiding this comment.
Weird that this did not fail the build! 🤔
The error
---------------------------------------------------------------------------
AttributeError Traceback (most recent call last)
Cell In[6], line 1
----> 1 scn.instrument_view(detector.sum('tof'),norm='log')
File ~/work/scippneutron/scippneutron/src/scippneutron/instrument_view.py:277, in instrument_view(scipp_obj, positions, pixel_size, components, **kwargs)
2[74](https://github.com/scipp/scippneutron/actions/runs/8966725725/job/24623041826#step:7:75) pixel_size = np.linalg.norm(pos_array[1] - pos_array[0])
2[76](https://github.com/scipp/scippneutron/actions/runs/8966725725/job/24623041826#step:7:77) fig = pp.scatter3d(scipp_obj, pos=positions, pixel_size=pixel_size, **kwargs)
--> 2[77](https://github.com/scipp/scippneutron/actions/runs/8966725725/job/24623041826#step:7:78) scene = fig.canvas.scene
279 # Add additional components from the beamline
280 if components:
AttributeError: 'Box' object has no attribute 'canvas'
is because we need to update plopp in the .buildconfig/ci-linux.yml file to 24.04
| prompt-toolkit==3.0.36 | ||
| # Temporary pinned until prompt-tookit conflict is resolved. | ||
| ipython==8.9.0 | ||
| scipp[all] |
There was a problem hiding this comment.
Weird that scipp[all] was removed. Should it be there or should it not?
There was a problem hiding this comment.
I want to say that yes it should be there? But why none of the actions are tripping up after removing scipp from base requirements 🤔
There was a problem hiding this comment.
Note that scipp is still there in the requirements further down (just without the [all])
There was a problem hiding this comment.
Well I guess then we shouldn't add the all optional identifier. It was added in #471
.github/workflows/docs.yml
Outdated
| python -m sphinx -j2 -v -b html -d doctrees docs html | ||
| python -m sphinx -j2 -v -b doctest -d doctrees docs html | ||
| python -m sphinx -W -j2 -v -b html -d doctrees docs html | ||
| python -m sphinx -W -j2 -v -b doctest -d doctrees docs html | ||
| find html -type f -name "*.ipynb" -not -path "html/_sources/*" -delete |
There was a problem hiding this comment.
Are the docs builds not being reported as failing because this line runs after the docs build and succeeds?
There was a problem hiding this comment.
I'm not sure, but for now I will create a new issue to track this so this PR isn't blocked. I will fix the issues in the notebooks manually.
There was a problem hiding this comment.
Created #510 to track this.
No description provided.