fix: replace calls to deprecated #351
Conversation
requirements/base.txt
Outdated
| # via matplotlib | ||
| kiwisolver==1.4.5 | ||
| # via matplotlib | ||
| matplotlib==3.9.0 | ||
| # via -r base.in | ||
| numpy==1.26.4 | ||
| numpy==2.0.0 |
There was a problem hiding this comment.
Is scipp compatible now with numpy 2.0? I thought we had not yet released that?
Can we make the changes with np.NINF etc without updating the dependencies?
There was a problem hiding this comment.
All checks have passed so maybe it's ok?
There was a problem hiding this comment.
Yes we can change without updating the dependencies
There was a problem hiding this comment.
Why did it pin numpy?
requirements/nightly.in
Outdated
| @@ -3,4 +3,4 @@ | |||
| # --- END OF CUSTOM SECTION --- | |||
| # The following was generated by 'tox -e deps', DO NOT EDIT MANUALLY! | |||
| matplotlib>=3.5 | |||
| https://github.com/scipp/scipp/releases/download/nightly/scipp-nightly-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl | |||
| https://github.com/scipp/scipp/releases/download/nightly/scipp-nightly-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl | |||
There was a problem hiding this comment.
I don't think we have dropped 3.10 yet?
There was a problem hiding this comment.
Not sure why this changed. I just ran tox -e deps 😕
There was a problem hiding this comment.
Yeah, it picks up the local env python and forces it through scipp/copier_template#163
There was a problem hiding this comment.
Good to know, thanks!
Fixes #350