deps: remove upper numpy bound #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems we need to release scippneutron and depend on the latest version here before this can be merged. |
|
I released ScippNexus 24.06.0 with the fix. |
pyproject.toml
Outdated
| "scippnexus>=23.12.1", # 23.12.0 and below deadlock in threaded use | ||
| "scippnexus>=24.6.0", # Below 24.6.0 incompatible with Numpy 2.0 |
There was a problem hiding this comment.
Since ESSsans does not require Numpy 2 we should not have such a lower bound, I think? That is, put back 23.12.1.
requirements/base.in
Outdated
| @@ -12,4 +12,4 @@ pythreejs | |||
| sciline>=24.06.0 | |||
| scipp>=23.8.0 | |||
| scippneutron>=23.9.0 | |||
| scippnexus>=23.12.1 | |||
| scippnexus>=24.6.0 | |||
There was a problem hiding this comment.
Since ScippNexus works also with lower versions, I also do not see a reason for the lower bound here. Revert to 23.12.1 and let pip-compile-multi deal with the rest?
jokasimr
force-pushed
the
remove-upper-snx
branch
from
93d93f3
to
77e8c94
Compare
SimonHeybrock
approved these changes
Jun 18, 2024
|
Waiting for scipp/plopp#351 |
jokasimr
force-pushed
the
remove-upper-snx
branch
from
77e8c94
to
9da385a
Compare
jokasimr
force-pushed
the
remove-upper-snx
branch
from
9da385a
to
2486e36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that scipp/scippnexus#215 is closed the upper bound on
numpycan be removed.Or, can it? We'll see what the ci says.