Working directory error #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danslo
reviewed
Apr 26, 2023
src/PackageSubmitter.php
Outdated
| @@ -46,7 +46,9 @@ private function getPackages(OutputInterface $output): array | |||
| private function getVendorState(array $packages): array | |||
| { | |||
| return [ | |||
| 'id' => $this->hasher->generateInstallIdHash(getcwd()), | |||
| 'id' => $this->hasher->generateInstallIdHash( | |||
| $this->packageResolverStrategy->getRootDirectory() | |||
There was a problem hiding this comment.
Sorry, I'm not currently behind a computer, but shouldn't this then be resolveRootPath rather than getRootDirectory? I do not see the latter defined anywhere.
There was a problem hiding this comment.
Yes, it should. Thanks for catching this. I had updated this to be correct in .../magento/vendor/sansec/..., but clearly didn't copy it out to where I committed from. I had initially created this as getRootDirectory() everywhere, but decided it'd be best to keep with the existing naming convention of 'resolveThing()'.
fredden
force-pushed
the
working-directory-error
branch
from
4548408
to
dced806
Compare
fredden
commented
Apr 26, 2023
fredden
force-pushed
the
working-directory-error
branch
from
dced806
to
66511b7
Compare
|
Let's go for it. Thanks for the contribution 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working to implement the new interface created in #14, I encountered an error when the working directory is not the same as the Composer root directory. This pull request replaces the call to
\getcwd()with a new resolver method to retrieve the correct directory.