Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run scanner tool directly, not via Composer/shell #7

Merged
merged 3 commits into from
Apr 27, 2023

Conversation

fredden
Copy link
Contributor

@fredden fredden commented Apr 26, 2023

This should fix the error that is showing up in #6 by implementing the new method for running the tool. Ref sansecio/composer-integrity-plugin#11 / sansecio/composer-integrity-plugin#14.

This is currently a draft pull request as it relies on a change that has not yet been accepted in the upstream tool.
sansecio/composer-integrity-plugin#15

Service/Scanner.php Outdated Show resolved Hide resolved
@pykettk
Copy link
Member

pykettk commented Apr 27, 2023

sansecio/composer-integrity-plugin#14 and sansecio/composer-integrity-plugin#15 are now merged upstream and have been tagged as 0.2.0. I think this is probably good to go once we update the Composer dependency to match and I've done some testing 🙂

@fredden fredden marked this pull request as ready for review April 27, 2023 13:51
@fredden fredden changed the title Run scanner tool directly, not via Composer Run scanner tool directly, not via Composer/shell Apr 27, 2023
@pykettk pykettk merged commit 15dc07e into element119:master Apr 27, 2023
@fredden fredden deleted the use-tool-via-php-not-shell branch April 27, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants