-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pivots] Support form-associate custom element (FACE) callbacks #3000
Comments
This issue has been linked to a new work item: W-11585205 |
I started implementing this, but there is an interesting wrinkle: FACE assumes you add So you only get one chance to make an element form-associated. This is a problem if we have class A which is registered first and not form-associated, and then class B which is registered second and is form-associated. A few possibilities:
Both options make me nervous. FWIW Polymer's polyfill seems to go for option #1 but not bother to ignore FACE callbacks for non-FACE elements. |
At this point name collision should not be a thing... so we should be fine to use formAssociated if the Ctor has it at the time of declaration of the upgradable class. |
Pivots were dropped in #3310 |
@rwaldron do we need this in locker? |
Description
As seen in Polymer's implementation, pivots (#2724) should support FACE callbacks such as
formAssociatedCallback
andformDisabledCallback
.The text was updated successfully, but these errors were encountered: