Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[alignment with standards] refactor AOM properties to be surfaced via ElementInternals #717

Closed
caridy opened this issue Oct 7, 2018 · 5 comments · Fixed by #3670
Closed

Comments

@caridy
Copy link
Contributor

caridy commented Oct 7, 2018

Description

Today, we are exposing AOM properties via this.template, this is changing in the spec, and it now will be exposed via createdCallback, who receives an argument internals (instance of ElementInternals). Changes are fairly simple in LWC, but there are some users using AOM properties from template that might get affected by this. Maybe we can keep both references for now, until this settles after 218.

Additionally, the introduction of the new hook is also important, which means that they now have the ability to do things right after the constructor finishes. I'm not entirely sure about the semantics of this hook.

@caridy
Copy link
Contributor Author

caridy commented Oct 7, 2018

@caridy
Copy link
Contributor Author

caridy commented Nov 2, 2018

The initial implementation was first attempted in #754, but eventually closed in favor of going slowly considering that there are still things TBD about that proposal. For now, we have removed all the shadowRoot patching for AOM in #794

@caridy
Copy link
Contributor Author

caridy commented May 23, 2019

There is a new PR for the Internals specification:

whatwg/html#4658

Once that is merged, we can start implementing that on our end.

@nolanlawson
Copy link
Collaborator

@caridy What is left to do here? Is this just about implementing attachInternals() and the various FACE callbacks now?

Related: #3000

@nolanlawson
Copy link
Collaborator

Related: #1023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants